diff options
| author | Carsey, Jaben <jaben.carsey@intel.com> | 2018-04-28 06:32:34 +0800 |
|---|---|---|
| committer | Yonghong Zhu <yonghong.zhu@intel.com> | 2018-05-04 13:03:06 +0800 |
| commit | 0caa769dbb87133c43774b1bb8821b34fa51753f (patch) | |
| tree | e0997fc165bb0ca5925d04f9ee191a81640030f7 /BaseTools/Source/Python/AutoGen/ValidCheckingInfoObject.py | |
| parent | def89ed0256fd903dbd1c54aa756fcb1fb5842df (diff) | |
| download | edk2-0caa769dbb87133c43774b1bb8821b34fa51753f.tar.gz edk2-0caa769dbb87133c43774b1bb8821b34fa51753f.tar.bz2 edk2-0caa769dbb87133c43774b1bb8821b34fa51753f.zip | |
BaseTools: AutoGen - refactor out a list
the lists were used in __init__ then converted to sets
instead just use the sets from the begining
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Diffstat (limited to 'BaseTools/Source/Python/AutoGen/ValidCheckingInfoObject.py')
| -rw-r--r-- | BaseTools/Source/Python/AutoGen/ValidCheckingInfoObject.py | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/BaseTools/Source/Python/AutoGen/ValidCheckingInfoObject.py b/BaseTools/Source/Python/AutoGen/ValidCheckingInfoObject.py index 0b4677b62a..b491b68f6e 100644 --- a/BaseTools/Source/Python/AutoGen/ValidCheckingInfoObject.py +++ b/BaseTools/Source/Python/AutoGen/ValidCheckingInfoObject.py @@ -262,7 +262,6 @@ class VAR_CHECK_PCD_VALID_LIST(VAR_CHECK_PCD_VALID_OBJ): super(VAR_CHECK_PCD_VALID_LIST, self).__init__(VarOffset, validlist, PcdDataType)
self.Type = 1
valid_num_list = []
- data_list = []
for item in self.rawdata:
valid_num_list.extend(item.split(','))
@@ -270,12 +269,11 @@ class VAR_CHECK_PCD_VALID_LIST(VAR_CHECK_PCD_VALID_OBJ): valid_num = valid_num.strip()
if valid_num.startswith('0x') or valid_num.startswith('0X'):
- data_list.append(int(valid_num, 16))
+ self.data.add(int(valid_num, 16))
else:
- data_list.append(int(valid_num))
+ self.data.add(int(valid_num))
- self.data = set(data_list)
self.Length = 5 + len(self.data) * self.StorageWidth
@@ -284,7 +282,6 @@ class VAR_CHECK_PCD_VALID_RANGE(VAR_CHECK_PCD_VALID_OBJ): super(VAR_CHECK_PCD_VALID_RANGE, self).__init__(VarOffset, validrange, PcdDataType)
self.Type = 2
RangeExpr = ""
- data_list = []
i = 0
for item in self.rawdata:
if i == 0:
@@ -294,8 +291,7 @@ class VAR_CHECK_PCD_VALID_RANGE(VAR_CHECK_PCD_VALID_OBJ): range_result = RangeExpression(RangeExpr, self.PcdDataType)(True)
for rangelist in range_result:
for obj in rangelist.pop():
- data_list.append((obj.start, obj.end))
- self.data = set(data_list)
+ self.data.add((obj.start, obj.end))
self.Length = 5 + len(self.data) * 2 * self.StorageWidth
|