summaryrefslogtreecommitdiffstats
path: root/BaseTools/Source/Python/Common/EdkLogger.py
diff options
context:
space:
mode:
authorYonghong Zhu <yonghong.zhu@intel.com>2018-09-05 11:26:15 +0800
committerYonghong Zhu <yonghong.zhu@intel.com>2018-09-12 13:20:46 +0800
commit4423f0bc613b5451feaa546c3f330ad625d65638 (patch)
treed31daacfd6389e589a419798ed48ab0d51d5a96d /BaseTools/Source/Python/Common/EdkLogger.py
parent4c0d19e5bf50c0edc33914a1d3e8b69943d5473f (diff)
downloadedk2-4423f0bc613b5451feaa546c3f330ad625d65638.tar.gz
edk2-4423f0bc613b5451feaa546c3f330ad625d65638.tar.bz2
edk2-4423f0bc613b5451feaa546c3f330ad625d65638.zip
BaseTools: Fix the RaiseError variable issue caused by 855698fb69f
The bug is that it cause the RaiseError always be set to TRUE even we call the function with FALSE parameter. Cc: Hess Chen <hesheng.chen@intel.com> Cc: Liming Gao <liming.gao@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com> Reviewed-by: Hess Chen <hesheng.chen@intel.com>
Diffstat (limited to 'BaseTools/Source/Python/Common/EdkLogger.py')
-rw-r--r--BaseTools/Source/Python/Common/EdkLogger.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/BaseTools/Source/Python/Common/EdkLogger.py b/BaseTools/Source/Python/Common/EdkLogger.py
index 80697bf09b..af7707482c 100644
--- a/BaseTools/Source/Python/Common/EdkLogger.py
+++ b/BaseTools/Source/Python/Common/EdkLogger.py
@@ -198,8 +198,8 @@ def error(ToolName, ErrorCode, Message=None, File=None, Line=None, ExtraData=Non
LogText = _ErrorMessageTemplateWithoutFile % TemplateDict
_ErrorLogger.log(ERROR, LogText)
- RaiseError = IsRaiseError
- if RaiseError:
+
+ if RaiseError and IsRaiseError:
raise FatalError(ErrorCode)
# Log information which should be always put out