summaryrefslogtreecommitdiffstats
path: root/BaseTools/Source/Python/Trim
diff options
context:
space:
mode:
authorZhiju Fan <zhijux.fan@intel.com>2019-01-11 13:04:44 +0800
committerFeng, Bob C <bob.c.feng@intel.com>2019-02-01 11:09:21 +0800
commit62cb98c254c8c24f610a427c948ca68ba43d7882 (patch)
tree358786f7d1d69a7a2f8aa2e632a8d7876830c529 /BaseTools/Source/Python/Trim
parent31e3eeb5e3d2d0b06416ad90d699de51d8761eda (diff)
downloadedk2-62cb98c254c8c24f610a427c948ca68ba43d7882.tar.gz
edk2-62cb98c254c8c24f610a427c948ca68ba43d7882.tar.bz2
edk2-62cb98c254c8c24f610a427c948ca68ba43d7882.zip
BaseTools:Double carriage return inserted from Trim.py on Python3
https://bugzilla.tianocore.org/show_bug.cgi?id=1379 Line 208 of BaseTools/Source/Python/Trim/Trim.py uses 'NewLines.append(os.linesep)' to insert a new line into the list that will be written to the output file. This causes the '\r\n' inserted with os.linesep to be written as '\r\r\n', causing some assemblers to error. Cc: Bob Feng <bob.c.feng@intel.com> Cc: Liming Gao <liming.gao@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com> Tested-by: Laszlo Ersek <lersek@redhat.com> Tested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Reviewed-by: Liming Gao <liming.gao@intel.com> Reviewed-by: Bob Feng <bob.c.feng@intel.com>
Diffstat (limited to 'BaseTools/Source/Python/Trim')
-rw-r--r--BaseTools/Source/Python/Trim/Trim.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/BaseTools/Source/Python/Trim/Trim.py b/BaseTools/Source/Python/Trim/Trim.py
index 4b3091bec3..51010bf326 100644
--- a/BaseTools/Source/Python/Trim/Trim.py
+++ b/BaseTools/Source/Python/Trim/Trim.py
@@ -205,7 +205,7 @@ def TrimPreprocessedFile(Source, Target, ConvertHex, TrimLong):
else:
if LineNumber > (len(NewLines) + 1):
for LineIndex in range(len(NewLines), LineNumber-1):
- NewLines.append(os.linesep)
+ NewLines.append(TAB_LINE_BREAK)
NewLines.append(Line)
LineNumber = None
EdkLogger.verbose("Now we have lines: %d" % len(NewLines))