BaseTools: Fix old python2 idioms

Based on "futurize -f lib2to3.fixes.fix_idioms"

* Change some type comparisons to isinstance() calls:
    type(x) == T -> isinstance(x, T)
    type(x) is T -> isinstance(x, T)
    type(x) != T -> not isinstance(x, T)
    type(x) is not T -> not isinstance(x, T)

* Change "while 1:" into "while True:".

* Change both

    v = list(EXPR)
    v.sort()
    foo(v)

and the more general

    v = EXPR
    v.sort()
    foo(v)

into

    v = sorted(EXPR)
    foo(v)

Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/BaseTools/Source/Python/UPT/Library/Misc.py b/BaseTools/Source/Python/UPT/Library/Misc.py
index e16d309ef8..28471d8123 100644
--- a/BaseTools/Source/Python/UPT/Library/Misc.py
+++ b/BaseTools/Source/Python/UPT/Library/Misc.py
@@ -514,7 +514,7 @@ class PathClass(object):
     # Check whether PathClass are the same

     #

     def __eq__(self, Other):

-        if type(Other) == type(self):

+        if isinstance(Other, type(self)):

             return self.Path == Other.Path

         else:

             return self.Path == str(Other)

@@ -819,11 +819,11 @@ def ConvertArchList(ArchList):
     if not ArchList:

         return NewArchList

 

-    if type(ArchList) == list:

+    if isinstance(ArchList, list):

         for Arch in ArchList:

             Arch = Arch.upper()

             NewArchList.append(Arch)

-    elif type(ArchList) == str:

+    elif isinstance(ArchList, str):

         ArchList = ArchList.upper()

         NewArchList.append(ArchList)