diff options
| author | Derek Lin <derek.lin2@hpe.com> | 2018-12-18 16:40:34 +0800 |
|---|---|---|
| committer | BobCF <bob.c.feng@intel.com> | 2018-12-19 13:24:18 +0800 |
| commit | 370544d1165ccbe64a2f932d432c6a5d65b179be (patch) | |
| tree | 6a3b9a3c42b64e3c62c6a52b8e8293b9afce7325 /BaseTools/Source/Python/build | |
| parent | 458539fb75f5a8cc3546293caa3cf83943eb9324 (diff) | |
| download | edk2-370544d1165ccbe64a2f932d432c6a5d65b179be.tar.gz edk2-370544d1165ccbe64a2f932d432c6a5d65b179be.tar.bz2 edk2-370544d1165ccbe64a2f932d432c6a5d65b179be.zip | |
BaseTools: Fix GenFds error doesn't break build.
Fix a bug because of b3497bad1221704a5dbc5da0b10f42625f1ad2ed.
Before the patch, when GenFds fail, the build continue and return success.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Derek Lin <derek.lin2@hpe.com>
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
Diffstat (limited to 'BaseTools/Source/Python/build')
| -rw-r--r-- | BaseTools/Source/Python/build/build.py | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py index cbbb291b2c..97271e634e 100644 --- a/BaseTools/Source/Python/build/build.py +++ b/BaseTools/Source/Python/build/build.py @@ -3,6 +3,7 @@ #
# Copyright (c) 2014, Hewlett-Packard Development Company, L.P.<BR>
# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2018, Hewlett Packard Enterprise Development, L.P.<BR>
#
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
@@ -1384,7 +1385,8 @@ class Build(): # genfds
if Target == 'fds':
- GenFdsApi(AutoGenObject.GenFdsCommandDict, self.Db)
+ if GenFdsApi(AutoGenObject.GenFdsCommandDict, self.Db):
+ EdkLogger.error("build", COMMAND_FAILURE)
return True
# run
@@ -2122,7 +2124,8 @@ class Build(): # Generate FD image if there's a FDF file found
#
GenFdsStart = time.time()
- GenFdsApi(Wa.GenFdsCommandDict, self.Db)
+ if GenFdsApi(Wa.GenFdsCommandDict, self.Db):
+ EdkLogger.error("build", COMMAND_FAILURE)
#
# Create MAP file for all platform FVs after GenFds.
|