diff options
| author | Yunhua Feng <yunhuax.feng@intel.com> | 2018-05-10 16:47:44 +0800 |
|---|---|---|
| committer | Yonghong Zhu <yonghong.zhu@intel.com> | 2018-05-22 19:33:35 +0800 |
| commit | 74f59e927520f50c4ebeeb2ccaa8e611b7d48dd1 (patch) | |
| tree | 3436eca3d487ff0572bc778135783bdb14bc5b4a /BaseTools/Source/Python | |
| parent | 1ea08a3dcdd61c7481ec78ad8b8037ee6ca45402 (diff) | |
| download | edk2-74f59e927520f50c4ebeeb2ccaa8e611b7d48dd1.tar.gz edk2-74f59e927520f50c4ebeeb2ccaa8e611b7d48dd1.tar.bz2 edk2-74f59e927520f50c4ebeeb2ccaa8e611b7d48dd1.zip | |
BaseTools: Fix bug PCD type in component is not same with Pcd section
Per DSC spec 3.11 [Components] Sections:
The PCD access methods (and storage methods) are selected on a platform
basis - it is not permitted to have a PCD listed in one of the Pcd
sections and use it differently in an individual module. For example,
if a PCD is listed in a [PcdsFixedAtBuild] section, it is not permitted
to list it in a <PcdsPatchableInModule> sub-section of an INF file.
but current code doesn't report error for this case.
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=951
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yunhua Feng <yunhuax.feng@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Diffstat (limited to 'BaseTools/Source/Python')
| -rw-r--r-- | BaseTools/Source/Python/AutoGen/AutoGen.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py b/BaseTools/Source/Python/AutoGen/AutoGen.py index 1e6511cdb5..cfa69655a9 100644 --- a/BaseTools/Source/Python/AutoGen/AutoGen.py +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py @@ -423,6 +423,7 @@ class WorkspaceAutoGen(AutoGen): PcdInPlatform = Platform.Pcds[key]
if PcdInPlatform.Type:
BuildData.Pcds[key].Type = PcdInPlatform.Type
+ BuildData.Pcds[key].Pending = False
if BuildData.MetaFile in Platform.Modules:
PlatformModule = Platform.Modules[str(BuildData.MetaFile)]
@@ -430,6 +431,7 @@ class WorkspaceAutoGen(AutoGen): PcdInPlatform = PlatformModule.Pcds[key]
if PcdInPlatform.Type:
BuildData.Pcds[key].Type = PcdInPlatform.Type
+ BuildData.Pcds[key].Pending = False
if TAB_PCDS_DYNAMIC_EX in BuildData.Pcds[key].Type:
if BuildData.IsBinaryModule:
|