diff options
| author | zhijufan <zhijux.fan@intel.com> | 2018-09-12 14:58:54 +0800 |
|---|---|---|
| committer | Yonghong Zhu <yonghong.zhu@intel.com> | 2018-09-18 09:41:26 +0800 |
| commit | ae57950fc878618083bca435fa4bc00d4bec97c1 (patch) | |
| tree | 4ef241855ea5102e97f2de8ff0becb56390b1350 /BaseTools/Source/Python | |
| parent | 3eb747c16be8fb9951f703f449e1287d4269ba12 (diff) | |
| download | edk2-ae57950fc878618083bca435fa4bc00d4bec97c1.tar.gz edk2-ae57950fc878618083bca435fa4bc00d4bec97c1.tar.bz2 edk2-ae57950fc878618083bca435fa4bc00d4bec97c1.zip | |
BaseTools: Fix a bug for Unused PCDs section display in the report
Fix a regression issue caused by ac4578af364, when there doesn't exist
not used PCD, it also display the not used Pcd section in the report.
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=1170
Cc: Liming Gao <liming.gao@intel.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Diffstat (limited to 'BaseTools/Source/Python')
| -rw-r--r-- | BaseTools/Source/Python/build/BuildReport.py | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Source/Python/build/BuildReport.py index c7fa1b97db..49bcd9c060 100644 --- a/BaseTools/Source/Python/build/BuildReport.py +++ b/BaseTools/Source/Python/build/BuildReport.py @@ -888,7 +888,17 @@ class PcdReport(object): if self.ConditionalPcds:
self.GenerateReportDetail(File, ModulePcdSet, 1)
if self.UnusedPcds:
- self.GenerateReportDetail(File, ModulePcdSet, 2)
+ IsEmpty = True
+ for Token in self.UnusedPcds:
+ TokenDict = self.UnusedPcds[Token]
+ for Type in TokenDict:
+ if TokenDict[Type]:
+ IsEmpty = False
+ break
+ if not IsEmpty:
+ break
+ if not IsEmpty:
+ self.GenerateReportDetail(File, ModulePcdSet, 2)
self.GenerateReportDetail(File, ModulePcdSet)
##
|