summaryrefslogtreecommitdiffstats
path: root/CryptoPkg
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé <devel@edk2.groups.io>2020-02-07 08:04:33 +0000
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>2020-02-10 07:09:47 +0000
commit4b026f0d5af36faf3a3629a3ad49c51b5b3be12f (patch)
tree62c4afdca4568e9a63c9c5f487c777500403f586 /CryptoPkg
parentb34ed98694f053bb70d8dbe11240accf06ac23ce (diff)
downloadedk2-4b026f0d5af36faf3a3629a3ad49c51b5b3be12f.tar.gz
edk2-4b026f0d5af36faf3a3629a3ad49c51b5b3be12f.tar.bz2
edk2-4b026f0d5af36faf3a3629a3ad49c51b5b3be12f.zip
SecurityPkg: Fix incorrect return value when File is NULL
The DxeTpmMeasureBootHandler and DxeTpm2MeasureBootHandler handlers are SECURITY2_FILE_AUTHENTICATION_HANDLER prototype. This prototype can not return EFI_INVALID_PARAMETER. The prototype documentation states it returns EFI_ACCESS_DENIED if: "The file specified by File and FileBuffer did not authenticate, and the platform policy dictates that the DXE Foundation may not use File." Correct the documentation, and add a early check, returning EFI_ACCESS_DENIED when File is NULL. Noticed while reviewing commit 6d57592740cdd0b6868baeef7929d6e6fef. Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: Jian J Wang <jian.j.wang@intel.com> Cc: Chao Zhang <chao.b.zhang@intel.com> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com> Reviewed-by: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
Diffstat (limited to 'CryptoPkg')
0 files changed, 0 insertions, 0 deletions