diff options
author | Dandan Bi <dandan.bi@intel.com> | 2018-09-09 22:26:07 +0800 |
---|---|---|
committer | Eric Dong <eric.dong@intel.com> | 2018-09-14 10:18:31 +0800 |
commit | 9c8e9e76bd06014e430ecfa6c8f8e21374005a29 (patch) | |
tree | 99a9a142572ca707f0c24092454b0d4aa1251bc4 /EmbeddedPkg/Drivers | |
parent | 52664c525223a36e5cb9b141b11dec413908b1dd (diff) | |
download | edk2-9c8e9e76bd06014e430ecfa6c8f8e21374005a29.tar.gz edk2-9c8e9e76bd06014e430ecfa6c8f8e21374005a29.tar.bz2 edk2-9c8e9e76bd06014e430ecfa6c8f8e21374005a29.zip |
EmbeddedPkg/VirtualKeyboard: Avoid notification called more than once
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=996
Issue:
In current code logic, when a key is pressed, it will search
the whole NotifyList to find whether a notification has been
registered with the keystroke. if yes, it will en-queue the
key for notification execution later. And now if different
notification functions have been registered with the same key,
then the key will be en-queued more than once. Then it will
cause the notification executed more than once.
This patch is to enhance the code logic to fix this issue.
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Diffstat (limited to 'EmbeddedPkg/Drivers')
-rw-r--r-- | EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c index 6609bc8dbe..daea9c47d2 100644 --- a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c +++ b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c @@ -1,7 +1,7 @@ /** @file
VirtualKeyboard driver
-Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
Copyright (c) 2018, Linaro Ltd. All rights reserved.<BR>
This program and the accompanying materials
@@ -1045,6 +1045,7 @@ VirtualKeyboardTimerHandler ( //
Enqueue (&VirtualKeyboardPrivate->QueueForNotify, &KeyData);
gBS->SignalEvent (VirtualKeyboardPrivate->KeyNotifyProcessEvent);
+ break;
}
}
|