diff options
| author | Ard Biesheuvel <ard.biesheuvel@linaro.org> | 2018-06-18 22:46:36 +0200 |
|---|---|---|
| committer | Ard Biesheuvel <ard.biesheuvel@linaro.org> | 2018-06-19 00:05:26 +0200 |
| commit | 02ec23abebcb271a16fae94f8e3659bb9282880d (patch) | |
| tree | ee5ca40d013b282ec41acffcb0b3a554fd155c30 /EmbeddedPkg | |
| parent | 1f739a851ce8ea8c9c4d9c4c7a5862fd44ab6ab4 (diff) | |
| download | edk2-02ec23abebcb271a16fae94f8e3659bb9282880d.tar.gz edk2-02ec23abebcb271a16fae94f8e3659bb9282880d.tar.bz2 edk2-02ec23abebcb271a16fae94f8e3659bb9282880d.zip | |
EmbeddedPkg/GdbSerialLib: avoid left shift of negative quantity
Clang complains about left shifting a negative value being undefined.
EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c:151:30:
error: shifting a negative signed value is undefined [-Werror,-Wshift-negative-value]
OutputData = (UINT8)((~DLAB<<7)|((BreakSet<<6)|((Parity<<3)|((StopBits<<2)| Data))));
Redefine all bit pattern constants as unsigned to work around this.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Diffstat (limited to 'EmbeddedPkg')
| -rw-r--r-- | EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c b/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c index 069d87ca78..7931d1ac4e 100644 --- a/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c +++ b/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c @@ -40,11 +40,11 @@ //---------------------------------------------
// UART Register Bit Defines
//---------------------------------------------
-#define LSR_TXRDY 0x20
-#define LSR_RXDA 0x01
-#define DLAB 0x01
-#define ENABLE_FIFO 0x01
-#define CLEAR_FIFOS 0x06
+#define LSR_TXRDY 0x20U
+#define LSR_RXDA 0x01U
+#define DLAB 0x01U
+#define ENABLE_FIFO 0x01U
+#define CLEAR_FIFOS 0x06U
|