diff options
| author | Star Zeng <star.zeng@intel.com> | 2018-07-30 10:35:09 +0800 |
|---|---|---|
| committer | Kinney, Michael D <michael.d.kinney@intel.com> | 2018-08-02 14:46:19 -0700 |
| commit | 559b5d5283ac6c0890b35e8684963e35f57f79b9 (patch) | |
| tree | 06f8baaa0305725aebb5cdc7aa582d81c1db4d60 /FmpDevicePkg | |
| parent | a4c35479b79457f8419f0e83c4d60122269ffc64 (diff) | |
| download | edk2-559b5d5283ac6c0890b35e8684963e35f57f79b9.tar.gz edk2-559b5d5283ac6c0890b35e8684963e35f57f79b9.tar.bz2 edk2-559b5d5283ac6c0890b35e8684963e35f57f79b9.zip | |
FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion
Some static tool reports "DeviceLibLowestSupportedVersion" is used,
but is uninitialized. It is false positive reporting based because
DeviceLibLowestSupportedVersion will have assigned value after
FmpDeviceGetLowestSupportedVersion() returns SUCCESS.
This patch updates the code to initialize
DeviceLibLowestSupportedVersion
to DEFAULT_LOWESTSUPPORTEDVERSION before calling
FmpDeviceGetLowestSupportedVersion().
It can pass the static tool's check.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Diffstat (limited to 'FmpDevicePkg')
| -rw-r--r-- | FmpDevicePkg/FmpDxe/FmpDxe.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c index b25a1511c7..095cebaa75 100644 --- a/FmpDevicePkg/FmpDxe/FmpDxe.c +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c @@ -229,6 +229,7 @@ GetLowestSupportedVersion ( //
// Check the FmpDeviceLib
//
+ DeviceLibLowestSupportedVersion = DEFAULT_LOWESTSUPPORTEDVERSION;
Status = FmpDeviceGetLowestSupportedVersion (&DeviceLibLowestSupportedVersion);
if (EFI_ERROR (Status)) {
DeviceLibLowestSupportedVersion = DEFAULT_LOWESTSUPPORTEDVERSION;
|