MdeModulePkg/Core: Create Migrated FV Info Hob for calculating hash (CVE-2019-11098)

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614

When we allocate pool to save the rebased PEIMs, the address will change
randomly, therefore the hash will change and result PCR0 change as well.
To avoid this, we save the raw PEIMs and use it to calculate hash.

The MigratedFvInfo HOB will never produce when
PcdMigrateTemporaryRamFirmwareVolumes is FALSE, because the PCD control
the total feature.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Debkumar De <debkumar.de@intel.com>
Cc: Harry Han <harry.han@intel.com>
Cc: Catharine West <catharine.west@intel.com>
Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>

3 files changed, 30 insertions, 0 deletions

diff --git a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
index 5bc0f8674d..b9a279ec73 100644
--- a/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
+++ b/MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c
@@ -1234,10 +1234,12 @@ EvacuateTempRam (
   EFI_FIRMWARE_VOLUME_HEADER    *FvHeader;

   EFI_FIRMWARE_VOLUME_HEADER    *ChildFvHeader;

   EFI_FIRMWARE_VOLUME_HEADER    *MigratedFvHeader;

+  EFI_FIRMWARE_VOLUME_HEADER    *RawDataFvHeader;

   EFI_FIRMWARE_VOLUME_HEADER    *MigratedChildFvHeader;

 

   PEI_CORE_FV_HANDLE            PeiCoreFvHandle;

   EFI_PEI_CORE_FV_LOCATION_PPI  *PeiCoreFvLocationPpi;

+  EDKII_MIGRATED_FV_INFO        MigratedFvInfo;

 

   ASSERT (Private->PeiMemoryInstalled);

 

@@ -1274,6 +1276,9 @@ EvacuateTempRam (
         (((EFI_PHYSICAL_ADDRESS)(UINTN) FvHeader + (FvHeader->FvLength - 1)) < Private->FreePhysicalMemoryTop)

         )

       ) {

+      //

+      // Allocate page to save the rebased PEIMs, the PEIMs will get dispatched later.

+      //

       Status =  PeiServicesAllocatePages (

                   EfiBootServicesCode,

                   EFI_SIZE_TO_PAGES ((UINTN) FvHeader->FvLength),

@@ -1281,6 +1286,17 @@ EvacuateTempRam (
                   );

       ASSERT_EFI_ERROR (Status);

 

+      //

+      // Allocate pool to save the raw PEIMs, which is used to keep consistent context across

+      // multiple boot and PCR0 will keep the same no matter if the address of allocated page is changed.

+      //

+      Status =  PeiServicesAllocatePages (

+                  EfiBootServicesCode,

+                  EFI_SIZE_TO_PAGES ((UINTN) FvHeader->FvLength),

+                  (EFI_PHYSICAL_ADDRESS *) &RawDataFvHeader

+                  );

+      ASSERT_EFI_ERROR (Status);

+

       DEBUG ((

         DEBUG_VERBOSE,

         "  Migrating FV[%d] from 0x%08X to 0x%08X\n",

@@ -1289,7 +1305,19 @@ EvacuateTempRam (
         (UINTN) MigratedFvHeader

         ));

 

+      //

+      // Copy the context to the rebased pages and raw pages, and create hob to save the

+      // information. The MigratedFvInfo HOB will never be produced when

+      // PcdMigrateTemporaryRamFirmwareVolumes is FALSE, because the PCD control the

+      // feature.

+      //

       CopyMem (MigratedFvHeader, FvHeader, (UINTN) FvHeader->FvLength);

+      CopyMem (RawDataFvHeader, MigratedFvHeader, (UINTN) FvHeader->FvLength);

+      MigratedFvInfo.FvOrgBase  = (UINT32) (UINTN) FvHeader;

+      MigratedFvInfo.FvNewBase  = (UINT32) (UINTN) MigratedFvHeader;

+      MigratedFvInfo.FvDataBase = (UINT32) (UINTN) RawDataFvHeader;

+      MigratedFvInfo.FvLength   = (UINT32) (UINTN) FvHeader->FvLength;

+      BuildGuidDataHob (&gEdkiiMigratedFvInfoGuid, &MigratedFvInfo, sizeof (MigratedFvInfo));

 

       //

       // Migrate any children for this FV now

diff --git a/MdeModulePkg/Core/Pei/PeiMain.h b/MdeModulePkg/Core/Pei/PeiMain.h
index 6d95a5d32c..c27e8fc33b 100644
--- a/MdeModulePkg/Core/Pei/PeiMain.h
+++ b/MdeModulePkg/Core/Pei/PeiMain.h
@@ -44,6 +44,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Guid/FirmwareFileSystem2.h>

 #include <Guid/FirmwareFileSystem3.h>

 #include <Guid/AprioriFileName.h>

+#include <Guid/MigratedFvInfo.h>

 

 ///

 /// It is an FFS type extension used for PeiFindFileEx. It indicates current

diff --git a/MdeModulePkg/Core/Pei/PeiMain.inf b/MdeModulePkg/Core/Pei/PeiMain.inf
index 5b36d516b3..0cf357371a 100644
--- a/MdeModulePkg/Core/Pei/PeiMain.inf
+++ b/MdeModulePkg/Core/Pei/PeiMain.inf
@@ -77,6 +77,7 @@
   ## CONSUMES   ## GUID      # Used to compare with FV's file system GUID and get the FV's file system format

   gEfiFirmwareFileSystem3Guid

   gStatusCodeCallbackGuid

+  gEdkiiMigratedFvInfoGuid                      ## SOMETIMES_PRODUCES     ## HOB

 

 [Ppis]

   gEfiPeiStatusCodePpiGuid                      ## SOMETIMES_CONSUMES # PeiReportStatusService is not ready if this PPI doesn't exist