diff options
author | Ruiyu Ni <ruiyu.ni@intel.com> | 2018-06-01 15:09:58 +0800 |
---|---|---|
committer | Ruiyu Ni <ruiyu.ni@intel.com> | 2018-06-05 13:49:17 +0800 |
commit | 6c252691c3be5f10df1708589821c8bb65244a8e (patch) | |
tree | bf1f5d75ccfb01876c40b836121dcf5b35db84de /MdeModulePkg/Library/DxeResetSystemLib | |
parent | f6406f94dca148f4492ddd1679ada73fe4ac323b (diff) | |
download | edk2-6c252691c3be5f10df1708589821c8bb65244a8e.tar.gz edk2-6c252691c3be5f10df1708589821c8bb65244a8e.tar.bz2 edk2-6c252691c3be5f10df1708589821c8bb65244a8e.zip |
MdeModulePkg/DxeResetSystemLib: Avoid depending on UefiRuntimeLib
Current DxeResetSystemLib depends on UefiRuntimeLib because it calls
EfiResetSystem() API exposed by UefiRuntimeLib.
Due to the commit:
"MdePkg/UefiRuntimeLib: Do not allow to be linked by DXE driver"
which reverts UefiRuntimeLib to only support DXE_RUNTIME_DRIVER,
removing UefiRuntimeLib dependency makes the DxeResetSystemLib
can be used by DXE drivers.
The patch also disallows the DxeResetSystemLib to be linked by
runtime driver, SMM drivers.
Runtime driver cannot link to this library because the gRT is not
converted when entering to RT.
SMM driver cannot link to this library because calling RT services
from SMM after EndOfDxe violates security guideline.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Diffstat (limited to 'MdeModulePkg/Library/DxeResetSystemLib')
-rw-r--r-- | MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c | 10 | ||||
-rw-r--r-- | MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.inf | 5 |
2 files changed, 7 insertions, 8 deletions
diff --git a/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c b/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c index ea452e3231..76bca223ae 100644 --- a/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c +++ b/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c @@ -14,7 +14,7 @@ #include <PiDxe.h>
#include <Library/ResetSystemLib.h>
-#include <Library/UefiRuntimeLib.h>
+#include <Library/UefiRuntimeServicesTableLib.h>
/**
This function causes a system-wide reset (cold reset), in which
@@ -30,7 +30,7 @@ ResetCold ( VOID
)
{
- EfiResetSystem (EfiResetCold, EFI_SUCCESS, 0, NULL);
+ gRT->ResetSystem (EfiResetCold, EFI_SUCCESS, 0, NULL);
}
/**
@@ -45,7 +45,7 @@ ResetWarm ( VOID
)
{
- EfiResetSystem (EfiResetWarm, EFI_SUCCESS, 0, NULL);
+ gRT->ResetSystem (EfiResetWarm, EFI_SUCCESS, 0, NULL);
}
/**
@@ -60,7 +60,7 @@ ResetShutdown ( VOID
)
{
- EfiResetSystem (EfiResetShutdown, EFI_SUCCESS, 0, NULL);
+ gRT->ResetSystem (EfiResetShutdown, EFI_SUCCESS, 0, NULL);
}
/**
@@ -94,5 +94,5 @@ ResetPlatformSpecific ( IN VOID *ResetData
)
{
- EfiResetSystem (EfiResetPlatformSpecific, EFI_SUCCESS, DataSize, ResetData);
+ gRT->ResetSystem (EfiResetPlatformSpecific, EFI_SUCCESS, DataSize, ResetData);
}
diff --git a/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.inf b/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.inf index 6eb2766b93..5cd52d8859 100644 --- a/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.inf +++ b/MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.inf @@ -19,7 +19,7 @@ FILE_GUID = C2BDE4F6-65EE-440B-87B5-83ABF10EF45B
MODULE_TYPE = DXE_DRIVER
VERSION_STRING = 1.0
- LIBRARY_CLASS = ResetSystemLib|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER
+ LIBRARY_CLASS = ResetSystemLib|DXE_CORE DXE_DRIVER UEFI_APPLICATION UEFI_DRIVER
#
# The following information is for reference only and not required by the build tools.
@@ -35,5 +35,4 @@ MdeModulePkg/MdeModulePkg.dec
[LibraryClasses]
- UefiRuntimeLib
-
+ UefiRuntimeServicesTableLib
|