diff options
| author | Shenglei Zhang <shenglei.zhang@intel.com> | 2019-10-15 11:36:34 +0800 |
|---|---|---|
| committer | Liming Gao <liming.gao@intel.com> | 2019-11-06 13:26:21 +0800 |
| commit | 0c1541d457832d3f68158cf61d21c30fe32bb885 (patch) | |
| tree | c1e6af62abda51107e825284b03083491f7f3c5b /MdeModulePkg/Universal | |
| parent | 3fb7e094efc87c46fffb2d755183bbe70da09396 (diff) | |
| download | edk2-0c1541d457832d3f68158cf61d21c30fe32bb885.tar.gz edk2-0c1541d457832d3f68158cf61d21c30fe32bb885.tar.bz2 edk2-0c1541d457832d3f68158cf61d21c30fe32bb885.zip | |
MdeModulePkg/SetupBrowserDxe: ASSERT GetBufferForValue(&Value)
Before called by GetBufferForValue(), Value has already been called
function IsTypeInBuffer to make sure the value must be buffer type.
So GetBufferForValue can not return NULL.
This commit adds ASSERT to assume (GetBufferForValue (&Value) is not
NULL.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
Diffstat (limited to 'MdeModulePkg/Universal')
| -rw-r--r-- | MdeModulePkg/Universal/SetupBrowserDxe/Expression.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c b/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c index 7f4929c2fc..d273d2aac3 100644 --- a/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c @@ -1281,7 +1281,10 @@ IfrToUint ( Result->Type = EFI_IFR_TYPE_UNDEFINED;
return EFI_SUCCESS;
}
+
+ ASSERT (GetBufferForValue (&Value) != NULL);
Result->Value.u64 = *(UINT64*) GetBufferForValue (&Value);
+
if (Value.Type == EFI_IFR_TYPE_BUFFER) {
FreePool (Value.Buffer);
}
|