MdePkg/MemoryLib: Refine InternalMemSetMem16|32|64 functions logic

This commit refines the logic for InternalMemSetMem16|32|64 functions. It
avoids using the decrement operator '--' for array index to prevent
possible mis-reports by static code checkers.

Please note that those modified functions are only consumed within
MemoryLib by APIs SetMem16|32|64, and those APIs will handle the case when
the input number of bytes to set is 0. Hence, the behavior of APIs
SetMem16|32|64 is not changed.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
Reviewed-by: Michael Kinney <michael.d.kinney@intel.com>

1 files changed, 9 insertions, 9 deletions

diff --git a/MdePkg/Library/UefiMemoryLib/MemLibGeneric.c b/MdePkg/Library/UefiMemoryLib/MemLibGeneric.c
index da02b6c52f..f1efdbb413 100644
--- a/MdePkg/Library/UefiMemoryLib/MemLibGeneric.c
+++ b/MdePkg/Library/UefiMemoryLib/MemLibGeneric.c
@@ -37,9 +37,9 @@ InternalMemSetMem16 (
   IN      UINT16                    Value

   )

 {

-  do {

-    ((UINT16*)Buffer)[--Length] = Value;

-  } while (Length != 0);

+  for (; Length != 0; Length--) {

+    ((UINT16*)Buffer)[Length - 1] = Value;

+  }

   return Buffer;

 }

 

@@ -61,9 +61,9 @@ InternalMemSetMem32 (
   IN      UINT32                    Value

   )

 {

-  do {

-    ((UINT32*)Buffer)[--Length] = Value;

-  } while (Length != 0);

+  for (; Length != 0; Length--) {

+    ((UINT32*)Buffer)[Length - 1] = Value;

+  }

   return Buffer;

 }

 

@@ -85,9 +85,9 @@ InternalMemSetMem64 (
   IN      UINT64                    Value

   )

 {

-  do {

-    ((UINT64*)Buffer)[--Length] = Value;

-  } while (Length != 0);

+  for (; Length != 0; Length--) {

+    ((UINT64*)Buffer)[Length - 1] = Value;

+  }

   return Buffer;

 }