summaryrefslogtreecommitdiffstats
path: root/MdePkg
diff options
context:
space:
mode:
authorNate DeSimone <nathaniel.l.desimone@intel.com>2023-09-29 14:40:34 -0700
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>2024-01-05 20:32:08 +0000
commit9cf1d03ebe076b3e3825dfebbc19fd6b52b5f336 (patch)
treeb2a61e0eb81e716b55ce0307113d9421f1146e66 /MdePkg
parent5a2490df0e6753928a1322436a96e01ffb000f3a (diff)
downloadedk2-9cf1d03ebe076b3e3825dfebbc19fd6b52b5f336.tar.gz
edk2-9cf1d03ebe076b3e3825dfebbc19fd6b52b5f336.tar.bz2
edk2-9cf1d03ebe076b3e3825dfebbc19fd6b52b5f336.zip
Add EFI_STATUS return to EMU_THUNK_PROTOCOL.SetTime()
There is an inconsistency between the UNIX and Windows implementations of EMU_THUNK_PROTOCOL.SetTime(). The Windows version returns an EFI_STATUS value whereas the the UNIX implementation is VOID. However, the UNIX implementation is an unimplemented stub whereas the Windows version is implementated. The current EMU_THUNK_PROTOCOL function pointer definition specifies a VOID return type. However, EMU_THUNK_PROTOCOL.SetTime() is close to the spec defined gRT->SetTime() except for missing the EFI_STATUS return type. Therefore, I conclude that the most sensible reconciliation is to add the EFI_STATUS return type to the protocol definition. Cc: Andrew Fish <afish@apple.com> Reviewed-by: Ray Ni <ray.ni@intel.com> Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Chasel Chiu <chasel.chiu@intel.com> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Diffstat (limited to 'MdePkg')
0 files changed, 0 insertions, 0 deletions