summaryrefslogtreecommitdiffstats
path: root/NetworkPkg/HttpBootDxe/HttpBootConfig.h
diff options
context:
space:
mode:
authorFu Siyuan <siyuan.fu@intel.com>2016-03-14 10:43:42 +0800
committerFu Siyuan <siyuan.fu@intel.com>2016-03-16 14:43:17 +0800
commit7537258100166bdf6e9f4203ac13e53a14f97490 (patch)
treeaf266f6ba498fc0ccc63a125026f6ae81715f6ca /NetworkPkg/HttpBootDxe/HttpBootConfig.h
parent6ddc2e438bd55e72b65806414c4fd712d50e612d (diff)
downloadedk2-7537258100166bdf6e9f4203ac13e53a14f97490.tar.gz
edk2-7537258100166bdf6e9f4203ac13e53a14f97490.tar.bz2
edk2-7537258100166bdf6e9f4203ac13e53a14f97490.zip
NetworkPkg: Fix the driver model issue in HTTP Boot driver.
The HTTP Boot driver have some UEFI driver model problems which will make the code ASSERT when it's disconnected. First, the driver opens the HttpSb protocol BY_CHILD without BY_DRIVER attribute. So the driver binding stop won't be called when HTTP driver is disconnected, so a child handle is left and made HTTP driver binding stop function goes into error. This patch remove this unnecessary OpenProtocol and only unload the HII from when both the IP4 and IP6 stack have been stopped completely. The second issue is the HTTP boot driver always use the driver's image handle as it's driver binding handle, it's not correct. HTTP Boot driver provides 2 separate driver binding protocols from IP4 and IP6 stack, so it has 2 driver binding handle. So this patch fix the code to use correct driver binding handle when create/open a HTTP child handle. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan <siyuan.fu@intel.com> Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>
Diffstat (limited to 'NetworkPkg/HttpBootDxe/HttpBootConfig.h')
-rw-r--r--NetworkPkg/HttpBootDxe/HttpBootConfig.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/NetworkPkg/HttpBootDxe/HttpBootConfig.h b/NetworkPkg/HttpBootDxe/HttpBootConfig.h
index a2afd18a88..e610fe8cd9 100644
--- a/NetworkPkg/HttpBootDxe/HttpBootConfig.h
+++ b/NetworkPkg/HttpBootDxe/HttpBootConfig.h
@@ -63,6 +63,7 @@ HttpBootConfigFormInit (
/**
Unload the configuration form, this includes: delete all the configuration
entries, uninstall the form callback protocol, and free the resources used.
+ The form will only be unload completely when both IP4 and IP6 stack are stopped.
@param[in] Private Pointer to the driver private data.