diff options
| author | Jiaxin Wu <jiaxin.wu@intel.com> | 2016-05-31 22:17:27 +0800 |
|---|---|---|
| committer | Jiaxin Wu <jiaxin.wu@intel.com> | 2016-06-13 11:51:47 +0800 |
| commit | 30526a51dda7e8db483f22a045f32f3a18eea5c7 (patch) | |
| tree | 0ec7afb8a314346e2560a9e688094fd3a5ab675f /NetworkPkg/HttpDxe/HttpProto.h | |
| parent | 5ffe214ae95be9cb3dfca3d1dc254ad9f1f6fe45 (diff) | |
| download | edk2-30526a51dda7e8db483f22a045f32f3a18eea5c7.tar.gz edk2-30526a51dda7e8db483f22a045f32f3a18eea5c7.tar.bz2 edk2-30526a51dda7e8db483f22a045f32f3a18eea5c7.zip | |
NetworkPkg: HttpDxe response/cancel issue fix
Remove timeout check for http body message receive. It should be handled
in HttpBootDxe driver for http response unblocking implementation. After
timeout removed, the Wrap date should not be freed immediately. Only the
TCP CompletionToken in Wrap date is canceled or signaled, the Wrap date
could be freed.
In addition, Http cancel token is also incorrect. Tcp Cancel should be called
to cancel TCP CompletionToken in Wrap date before close it directly. Otherwise,
some exception behavior may happened.
This patch also refine the coding style for HttpDxe driver.
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Ye Ting <ting.ye@intel.com>
Cc: Zhang Lubo <lubo.zhang@intel.com>
Cc: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com>
Cc: Gary Lin <glin@suse.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
Reviewed-by: Gary Lin <glin@suse.com>
Reviewed-by: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
Tested-by: Gary Lin <glin@suse.com>
Tested-by: Hegde Nagaraj P <nagaraj-p.hegde@hpe.com>
Diffstat (limited to 'NetworkPkg/HttpDxe/HttpProto.h')
| -rw-r--r-- | NetworkPkg/HttpDxe/HttpProto.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/NetworkPkg/HttpDxe/HttpProto.h b/NetworkPkg/HttpDxe/HttpProto.h index cdad5b0e48..e1fd785b2c 100644 --- a/NetworkPkg/HttpDxe/HttpProto.h +++ b/NetworkPkg/HttpDxe/HttpProto.h @@ -525,7 +525,6 @@ HttpTcpReceiveHeader ( @param[in] Wrap The HTTP token's wrap data.
@param[in] HttpMsg The HTTP message data.
- @param[in] Timeout The time to wait for receiving the body packet.
@retval EFI_SUCCESS The HTTP body is received.
@retval Others Other error as indicated.
@@ -534,8 +533,7 @@ HttpTcpReceiveHeader ( EFI_STATUS
HttpTcpReceiveBody (
IN HTTP_TOKEN_WRAP *Wrap,
- IN EFI_HTTP_MESSAGE *HttpMsg,
- IN EFI_EVENT Timeout
+ IN EFI_HTTP_MESSAGE *HttpMsg
);
/**
|