summaryrefslogtreecommitdiffstats
path: root/NetworkPkg/IScsiDxe
diff options
context:
space:
mode:
authorZhang Lubo <lubo.zhang@intel.com>2016-08-01 16:33:26 +0800
committerJiaxin Wu <jiaxin.wu@intel.com>2016-08-18 13:54:07 +0800
commit3cb5b9970fbdf69362d1656f7e89808fc4f2bb2e (patch)
tree0e20a46e2c96e477048bccc68092c2c191741dd8 /NetworkPkg/IScsiDxe
parent79d909849c0e3d6a40989473accfee95e2c3660e (diff)
downloadedk2-3cb5b9970fbdf69362d1656f7e89808fc4f2bb2e.tar.gz
edk2-3cb5b9970fbdf69362d1656f7e89808fc4f2bb2e.tar.bz2
edk2-3cb5b9970fbdf69362d1656f7e89808fc4f2bb2e.zip
NetworkPkg: Fix assert issue in iSCSI driver
The bug is caused by using already freed memory. If there is already an attempt and execute 'reconnect -r' command, all the AttemptConfig structure will be freed, but the mCallbackInfo->Current is not configured as null and this pointer will be used again in IScsiFormExtractConfig. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo <lubo.zhang@intel.com> Cc: Fu Siyuan <siyuan.fu@intel.com> Cc: Ye Ting <ting.ye@intel.com> Cc: Wu Jiaxin <jiaxin.wu@intel.com> Reviewed-by: Ye Ting <ting.ye@intel.com> Reviewed-by: Fu Siyuan <siyuan.fu@intel.com> Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>
Diffstat (limited to 'NetworkPkg/IScsiDxe')
-rw-r--r--NetworkPkg/IScsiDxe/IScsiMisc.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c b/NetworkPkg/IScsiDxe/IScsiMisc.c
index deebf5d9a3..a39c268d65 100644
--- a/NetworkPkg/IScsiDxe/IScsiMisc.c
+++ b/NetworkPkg/IScsiDxe/IScsiMisc.c
@@ -900,6 +900,8 @@ EXIT:
gBS->CloseEvent (Private->ExitBootServiceEvent);
+ mCallbackInfo->Current = NULL;
+
FreePool (Private);
return Status;
}