diff options
| author | Liran Alon <liran.alon@oracle.com> | 2020-04-01 01:56:37 +0300 |
|---|---|---|
| committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2020-04-01 14:12:09 +0000 |
| commit | e210fc130e5c9738909dca432bbf8bf277ba6e37 (patch) | |
| tree | 2986442b32988c567c17fb2f91fbebf71e50e8a7 /NetworkPkg/Ip6Dxe | |
| parent | 98936dc4f44b4ef47e7221d435de06a0813aa00a (diff) | |
| download | edk2-e210fc130e5c9738909dca432bbf8bf277ba6e37.tar.gz edk2-e210fc130e5c9738909dca432bbf8bf277ba6e37.tar.bz2 edk2-e210fc130e5c9738909dca432bbf8bf277ba6e37.zip | |
OvmfPkg/PvScsiDxe: Refactor setup of rings to separate function
Previous to this change, PvScsiFreeRings() was not undoing all
operations that was done by PvScsiInitRings().
This is because PvScsiInitRings() was both preparing rings (Allocate
memory and map it for device DMA) and setup the rings against device by
issueing a device command. While PvScsiFreeRings() only unmaps the rings
and free their memory.
Driver do not have a functional error as it makes sure to reset device
before every call site to PvScsiFreeRings(). However, this is not
intuitive.
Therefore, prefer to refactor the setup of the ring against device to a
separate function than PvScsiInitRings().
Signed-off-by: Liran Alon <liran.alon@oracle.com>
Message-Id: <20200331225637.123318-1-liran.alon@oracle.com>
[lersek@redhat.com: rename FreeDMACommBuffer label to FreeDmaCommBuffer]
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Diffstat (limited to 'NetworkPkg/Ip6Dxe')
0 files changed, 0 insertions, 0 deletions