diff options
author | Laszlo Ersek <lersek@redhat.com> | 2019-09-07 14:11:31 +0200 |
---|---|---|
committer | Laszlo Ersek <lersek@redhat.com> | 2019-10-09 09:40:10 +0200 |
commit | bf7249df9cbd0b5096f8f737b2439b6d17be89c3 (patch) | |
tree | da4f44629b820202b28748a46d9f208e2c73b178 /NetworkPkg/Mtftp4Dxe | |
parent | c486a33049bbe59eed99255fa772fba63cdbb73a (diff) | |
download | edk2-bf7249df9cbd0b5096f8f737b2439b6d17be89c3.tar.gz edk2-bf7249df9cbd0b5096f8f737b2439b6d17be89c3.tar.bz2 edk2-bf7249df9cbd0b5096f8f737b2439b6d17be89c3.zip |
NetworkPkg: fix CloseProtocol & UninstallMultipleProtocolInterfaces calls
Both the "ControllerHandle" parameter of CloseProtocol() and the "Handle"
parameter of UninstallMultipleProtocolInterfaces() have type EFI_HANDLE,
not (EFI_HANDLE*).
This patch fixes actual bugs. The issues have been dormant likely because
they are on error paths. (Or, in case of TlsAuthConfigDxe, because the
driver is unloaded likely very infrequently.)
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'NetworkPkg/Mtftp4Dxe')
-rw-r--r-- | NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c b/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c index ae9e65544a..06c4e202d3 100644 --- a/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c +++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c @@ -592,7 +592,7 @@ Mtftp4ServiceBindingCreateChild ( MtftpSb->ConnectUdp->UdpHandle,
&gEfiUdp4ProtocolGuid,
gMtftp4DriverBinding.DriverBindingHandle,
- ChildHandle
+ *ChildHandle
);
goto ON_ERROR;
}
|