diff options
| author | Rabeda, Maciej <maciej.rabeda@intel.com> | 2019-10-14 20:37:28 +0800 |
|---|---|---|
| committer | Siyuan Fu <siyuan.fu@intel.com> | 2019-10-21 14:50:51 +0800 |
| commit | 61bb6eeb4d93c0a34c1995d87914ab41398f9550 (patch) | |
| tree | 2a46263a4bc6667f455e9c59881fbad60bd14862 /NetworkPkg/NetworkPkg.dec | |
| parent | 109197ee116b80f70acafe91e36e7172efcb9c6c (diff) | |
| download | edk2-61bb6eeb4d93c0a34c1995d87914ab41398f9550.tar.gz edk2-61bb6eeb4d93c0a34c1995d87914ab41398f9550.tar.bz2 edk2-61bb6eeb4d93c0a34c1995d87914ab41398f9550.zip | |
NetworkPkg/SnpDxe: Add PCD to remove ExitBootServices event from SNP driver.
Patch addresses Bugzilla #1974.
During ExitBootServices stage, drivers should not call any
functions known to use Memory Allocation Services. One of such
functions (as per UEFI spec) is UNDI->Shutdown().
Since UNDI drivers during ExitBootServices phase are expected
to put the adapter to such a state that it will not perform any DMA
operations, there is no need to interface UNDI by SNP driver during
that phase.
Finally, since ExitBootServices event notification function in SNP
only calls UNDI->Shutdown() and Stop() functions, there is no need
to create this event at all. Adding PCD to control creation of event
reacting to ExitBootServices() call so that systems with UNDIs relying
on SNP to call their Shutdown() and Stop() can still work.
Change-Id: Idd76f26d2e8ff7cf88b2d75e2d524c74211f2e89
Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>
Signed-off-by: Maciej Rabeda <maciej.rabeda@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Diffstat (limited to 'NetworkPkg/NetworkPkg.dec')
| -rw-r--r-- | NetworkPkg/NetworkPkg.dec | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/NetworkPkg/NetworkPkg.dec b/NetworkPkg/NetworkPkg.dec index 944b1d1501..66e500cbea 100644 --- a/NetworkPkg/NetworkPkg.dec +++ b/NetworkPkg/NetworkPkg.dec @@ -109,6 +109,13 @@ # @Prompt TFTP block size.
gEfiNetworkPkgTokenSpaceGuid.PcdTftpBlockSize|0x0|UINT64|0x1000000B
+ ## Indicates whether SnpDxe driver will create an event that will be notified
+ # upon gBS->ExitBootServices() call.
+ # TRUE - Event being triggered upon ExitBootServices call will be created
+ # FALSE - Event being triggered upon ExitBootServices call will NOT be created
+ # @Prompt Indicates whether SnpDxe creates event for ExitBootServices() call.
+ gEfiNetworkPkgTokenSpaceGuid.PcdSnpCreateExitBootServicesEvent|TRUE|BOOLEAN|0x1000000C
+
[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
## IPv6 DHCP Unique Identifier (DUID) Type configuration (From RFCs 3315 and 6355).
# 01 = DUID Based on Link-layer Address Plus Time [DUID-LLT]
|