summaryrefslogtreecommitdiffstats
path: root/NetworkPkg/SnpDxe/Snp.h
diff options
context:
space:
mode:
authorRabeda, Maciej <maciej.rabeda@intel.com>2019-10-14 20:37:28 +0800
committerSiyuan Fu <siyuan.fu@intel.com>2019-10-21 14:50:51 +0800
commit61bb6eeb4d93c0a34c1995d87914ab41398f9550 (patch)
tree2a46263a4bc6667f455e9c59881fbad60bd14862 /NetworkPkg/SnpDxe/Snp.h
parent109197ee116b80f70acafe91e36e7172efcb9c6c (diff)
downloadedk2-61bb6eeb4d93c0a34c1995d87914ab41398f9550.tar.gz
edk2-61bb6eeb4d93c0a34c1995d87914ab41398f9550.tar.bz2
edk2-61bb6eeb4d93c0a34c1995d87914ab41398f9550.zip
NetworkPkg/SnpDxe: Add PCD to remove ExitBootServices event from SNP driver.
Patch addresses Bugzilla #1974. During ExitBootServices stage, drivers should not call any functions known to use Memory Allocation Services. One of such functions (as per UEFI spec) is UNDI->Shutdown(). Since UNDI drivers during ExitBootServices phase are expected to put the adapter to such a state that it will not perform any DMA operations, there is no need to interface UNDI by SNP driver during that phase. Finally, since ExitBootServices event notification function in SNP only calls UNDI->Shutdown() and Stop() functions, there is no need to create this event at all. Adding PCD to control creation of event reacting to ExitBootServices() call so that systems with UNDIs relying on SNP to call their Shutdown() and Stop() can still work. Change-Id: Idd76f26d2e8ff7cf88b2d75e2d524c74211f2e89 Reviewed-by: Siyuan Fu <siyuan.fu@intel.com> Signed-off-by: Maciej Rabeda <maciej.rabeda@intel.com> Cc: Siyuan Fu <siyuan.fu@intel.com> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Diffstat (limited to 'NetworkPkg/SnpDxe/Snp.h')
-rw-r--r--NetworkPkg/SnpDxe/Snp.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/NetworkPkg/SnpDxe/Snp.h b/NetworkPkg/SnpDxe/Snp.h
index e6b6293039..9e4b7d6f86 100644
--- a/NetworkPkg/SnpDxe/Snp.h
+++ b/NetworkPkg/SnpDxe/Snp.h
@@ -1,7 +1,7 @@
/** @file
Declaration of strctures and functions for SnpDxe driver.
-Copyright (c) 2004 - 2016, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2004 - 2019, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -26,6 +26,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#include <Library/UefiLib.h>
#include <Library/MemoryAllocationLib.h>
#include <Library/PrintLib.h>
+#include <Library/PcdLib.h>
#include <IndustryStandard/Pci.h>
#include <IndustryStandard/Acpi.h>