summaryrefslogtreecommitdiffstats
path: root/NetworkPkg
diff options
context:
space:
mode:
authorNeo Hsueh <Hong-Chih.Hsueh@amd.com>2024-08-01 14:11:57 -0500
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>2024-09-03 06:24:43 +0000
commit72cf76868ce7b7cda1ba5f9eb28693557ff10256 (patch)
tree78c12977303d40204265ec6d818ebd4728607704 /NetworkPkg
parentcb9bdf37532e8b75c38bd4874f9c797d7f66ed30 (diff)
downloadedk2-72cf76868ce7b7cda1ba5f9eb28693557ff10256.tar.gz
edk2-72cf76868ce7b7cda1ba5f9eb28693557ff10256.tar.bz2
edk2-72cf76868ce7b7cda1ba5f9eb28693557ff10256.zip
NetworkPkg/WifiConnectionManagerDxe: Fix Connection Manager HII errors
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4824 Fix the wrong logic in WifiMgrDxeHiiConfigAccessCallback with EFI_BROWSER_ACTION_CHANGING action. Cc: Jiangang He <jiangang.he@amd.com> Cc: Abner Chang <abner.chang@amd.com> Signed-off-by: Neo Hsueh <Hong-Chih.Hsueh@amd.com>
Diffstat (limited to 'NetworkPkg')
-rw-r--r--NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrHiiConfigAccess.c34
1 files changed, 1 insertions, 33 deletions
diff --git a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrHiiConfigAccess.c b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrHiiConfigAccess.c
index f242bdf056..00804e5467 100644
--- a/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrHiiConfigAccess.c
+++ b/NetworkPkg/WifiConnectionManagerDxe/WifiConnectionMgrHiiConfigAccess.c
@@ -1490,6 +1490,7 @@ WifiMgrDxeHiiConfigAccessCallback (
} else if (Action == EFI_BROWSER_ACTION_FORM_CLOSE) {
switch (QuestionId) {
case KEY_EAP_ENROLL_CERT_FROM_FILE:
+ case KEY_REFRESH_NETWORK_LIST:
if (Private->CurrentNic->UserSelectedProfile == NULL) {
break;
@@ -1911,39 +1912,6 @@ WifiMgrDxeHiiConfigAccessCallback (
NULL
);
}
-
- if (Private->CurrentNic->UserSelectedProfile == NULL) {
- break;
- }
-
- Profile = Private->CurrentNic->UserSelectedProfile;
-
- //
- // Enter the network connection configuration page
- // Recovery from restored data
- //
- if (HiiSetString (Private->RegisteredHandle, STRING_TOKEN (STR_SSID), Profile->SSId, NULL) == 0) {
- return EFI_OUT_OF_RESOURCES;
- }
-
- IfrNvData->SecurityType = Profile->SecurityType;
- if (HiiSetString (
- Private->RegisteredHandle,
- STRING_TOKEN (STR_SECURITY_TYPE),
- mSecurityType[IfrNvData->SecurityType],
- NULL
- ) == 0)
- {
- return EFI_OUT_OF_RESOURCES;
- }
-
- if ( (IfrNvData->SecurityType == SECURITY_TYPE_WPA2_ENTERPRISE)
- || (IfrNvData->SecurityType == SECURITY_TYPE_WPA3_ENTERPRISE))
- {
- IfrNvData->EapAuthMethod = Profile->EapAuthMethod;
- IfrNvData->EapSecondAuthMethod = Profile->EapSecondAuthMethod;
- StrCpyS (IfrNvData->EapIdentity, EAP_IDENTITY_SIZE, Profile->EapIdentity);
- }
}
break;