summaryrefslogtreecommitdiffstats
path: root/OvmfPkg/CpuS3DataDxe
diff options
context:
space:
mode:
authorMichael Brown <mcb30@ipxe.org>2023-05-09 12:09:33 +0000
committermergify[bot] <37929162+mergify[bot]@users.noreply.github.com>2023-05-09 22:09:50 +0000
commitbee67e0c142af6599a85aa7640094816b8a24c4f (patch)
tree55d36a942df6af8cd89bcd1c395b554292a1ba4d /OvmfPkg/CpuS3DataDxe
parentae0be176a83efebe9a8c13d2124151f7dd13443a (diff)
downloadedk2-bee67e0c142af6599a85aa7640094816b8a24c4f.tar.gz
edk2-bee67e0c142af6599a85aa7640094816b8a24c4f.tar.bz2
edk2-bee67e0c142af6599a85aa7640094816b8a24c4f.zip
OvmfPkg: Relax assertion that interrupts do not occur at TPL_HIGH_LEVEL
At TPL_HIGH_LEVEL, CPU interrupts are disabled (as per the UEFI specification) and so we should never encounter a situation in which an interrupt occurs at TPL_HIGH_LEVEL. The specification also restricts usage of TPL_HIGH_LEVEL to the firmware itself. However, nothing actually prevents a UEFI application from calling gBS->RaiseTPL(TPL_HIGH_LEVEL) and then violating the invariant by enabling interrupts via the STI or equivalent instruction. Some versions of the Microsoft Windows bootloader are known to do this. NestedInterruptTplLib maintains the invariant that interrupts are disabled at TPL_HIGH_LEVEL (even when performing the dark art of deliberately manipulating the stack so that IRET will return with interrupts still disabled), but does not itself rely on external code maintaining this invariant. Relax the assertion that the interrupted TPL is below TPL_HIGH_LEVEL to an error message, to allow UEFI applications such as these versions of the Microsoft Windows bootloader to continue to function. Debugged-by: Gerd Hoffmann <kraxel@redhat.com> Debugged-by: Laszlo Ersek <lersek@redhat.com> Ref: https://bugzilla.redhat.com/show_bug.cgi?id=2189136 Signed-off-by: Michael Brown <mcb30@ipxe.org> Acked-by: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'OvmfPkg/CpuS3DataDxe')
0 files changed, 0 insertions, 0 deletions