diff options
| author | Laszlo Ersek <lersek@redhat.com> | 2016-05-09 19:26:37 +0200 |
|---|---|---|
| committer | Laszlo Ersek <lersek@redhat.com> | 2016-05-17 20:48:33 +0200 |
| commit | b2f4da3956debf656279a0836500b6989a85e276 (patch) | |
| tree | 286832ac9505ae93df53d6b1e127d8a866fb55b1 /OvmfPkg/Include | |
| parent | ac759060e6272c3e451808c9ba40927d76890f26 (diff) | |
| download | edk2-b2f4da3956debf656279a0836500b6989a85e276.tar.gz edk2-b2f4da3956debf656279a0836500b6989a85e276.tar.bz2 edk2-b2f4da3956debf656279a0836500b6989a85e276.zip | |
OvmfPkg: replace PcdAcpiPmBaseAddress with PIIX4_PMBA_VALUE
In the next patches, we'll differentiate the PMBA IO port address that we
program on PIIX4 vs. Q35.
Normally we'd just turn PcdAcpiPmBaseAddress into a dynamic PCD. However,
because we need this value in BaseRomAcpiTimerLib too (which cannot access
RAM and dynamic PCDs), it must remain a build time constant. We will
introduce its Q35 counterpart later.
As first step, replace the PCD with a new macro in "OvmfPlatforms.h";
Jordan prefers the latter to fixed PCDs in this instance.
Cc: Gabriel Somlo <somlo@cmu.edu>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1333238
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Tested-by: Gabriel Somlo <somlo@cmu.edu>
Diffstat (limited to 'OvmfPkg/Include')
| -rw-r--r-- | OvmfPkg/Include/OvmfPlatforms.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/OvmfPkg/Include/OvmfPlatforms.h b/OvmfPkg/Include/OvmfPlatforms.h index 43ab01d57c..ee9f6554d0 100644 --- a/OvmfPkg/Include/OvmfPlatforms.h +++ b/OvmfPkg/Include/OvmfPlatforms.h @@ -28,6 +28,11 @@ PCI_LIB_ADDRESS (0, 0, 0, PCI_DEVICE_ID_OFFSET)
//
+// Values we program into the PM base address registers
+//
+#define PIIX4_PMBA_VALUE 0xB000
+
+//
// Common bits in same-purpose registers
//
#define PMBA_RTE BIT0
|