diff options
| author | Laszlo Ersek <lersek@redhat.com> | 2018-03-01 14:41:01 +0100 |
|---|---|---|
| committer | Laszlo Ersek <lersek@redhat.com> | 2018-03-06 13:30:03 +0100 |
| commit | 154dcd6c58a397a6d31a8fe0bc3dab70b916f33a (patch) | |
| tree | b5bec4a752b229693ca54373520d9db4d2785ad7 /OvmfPkg/Library/BaseMemEncryptSevLib | |
| parent | 5b5028e67b4fa34820e4d9a742cce9fca65c904c (diff) | |
| download | edk2-154dcd6c58a397a6d31a8fe0bc3dab70b916f33a.tar.gz edk2-154dcd6c58a397a6d31a8fe0bc3dab70b916f33a.tar.bz2 edk2-154dcd6c58a397a6d31a8fe0bc3dab70b916f33a.zip | |
OvmfPkg/MemEncryptSevLib: clean up MemEncryptSevSetPageEncMask() decl
The declaration and the definition(s) of the function should have
identical leading comments and/or identical parameter lists. Replace any
leftover "clear" references to the C-bit with "set" references. Also
remove any excess space in the comment block, and unindent the trailing
"**/" if necessary. Correct several parameter references.
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Tested-by: Brijesh Singh <brijesh.singh@amd.com>
Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>
Diffstat (limited to 'OvmfPkg/Library/BaseMemEncryptSevLib')
| -rw-r--r-- | OvmfPkg/Library/BaseMemEncryptSevLib/Ia32/MemEncryptSevLib.c | 32 | ||||
| -rw-r--r-- | OvmfPkg/Library/BaseMemEncryptSevLib/X64/MemEncryptSevLib.c | 17 |
2 files changed, 24 insertions, 25 deletions
diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/Ia32/MemEncryptSevLib.c b/OvmfPkg/Library/BaseMemEncryptSevLib/Ia32/MemEncryptSevLib.c index d6067c52aa..614c97b23b 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/Ia32/MemEncryptSevLib.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/Ia32/MemEncryptSevLib.c @@ -57,29 +57,29 @@ MemEncryptSevClearPageEncMask ( /**
This function sets memory encryption bit for the memory region specified by
- BaseAddress and Number of pages from the current page table context.
+ BaseAddress and NumPages from the current page table context.
- @param[in] Cr3BaseAddress Cr3 Base Address (if zero then use current
- CR3)
- @param[in] BaseAddress The physical address that is the start
- address of a memory region.
- @param[in] NumberOfPages The number of pages from start memory
- region.
- @param[in] Flush Flush the caches before clearing the bit
- (mostly TRUE except MMIO addresses)
+ @param[in] Cr3BaseAddress Cr3 Base Address (if zero then use
+ current CR3)
+ @param[in] BaseAddress The physical address that is the start
+ address of a memory region.
+ @param[in] NumPages The number of pages from start memory
+ region.
+ @param[in] Flush Flush the caches before setting the bit
+ (mostly TRUE except MMIO addresses)
- @retval RETURN_SUCCESS The attributes were set for the memory
- region.
- @retval RETURN_INVALID_PARAMETER Number of pages is zero.
- @retval RETURN_UNSUPPORTED Clearing memory encryption attribute is not
- supported
- **/
+ @retval RETURN_SUCCESS The attributes were set for the memory
+ region.
+ @retval RETURN_INVALID_PARAMETER Number of pages is zero.
+ @retval RETURN_UNSUPPORTED Setting the memory encryption attribute
+ is not supported
+**/
RETURN_STATUS
EFIAPI
MemEncryptSevSetPageEncMask (
IN PHYSICAL_ADDRESS Cr3BaseAddress,
IN PHYSICAL_ADDRESS BaseAddress,
- IN UINTN NumberOfPages,
+ IN UINTN NumPages,
IN BOOLEAN Flush
)
{
diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/MemEncryptSevLib.c b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/MemEncryptSevLib.c index 5b8bc73764..f165722ae5 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/MemEncryptSevLib.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/MemEncryptSevLib.c @@ -60,25 +60,24 @@ MemEncryptSevClearPageEncMask ( }
/**
-
- This function clears memory encryption bit for the memory region specified by
- BaseAddress and Number of pages from the current page table context.
+ This function sets memory encryption bit for the memory region specified by
+ BaseAddress and NumPages from the current page table context.
@param[in] Cr3BaseAddress Cr3 Base Address (if zero then use
current CR3)
@param[in] BaseAddress The physical address that is the start
address of a memory region.
- @param[in] NumberOfPages The number of pages from start memory
+ @param[in] NumPages The number of pages from start memory
region.
- @param[in] Flush Flush the caches before clearing the bit
+ @param[in] Flush Flush the caches before setting the bit
(mostly TRUE except MMIO addresses)
- @retval RETURN_SUCCESS The attributes were cleared for the
- memory region.
+ @retval RETURN_SUCCESS The attributes were set for the memory
+ region.
@retval RETURN_INVALID_PARAMETER Number of pages is zero.
- @retval RETURN_UNSUPPORTED Clearing the memory encryption attribute
+ @retval RETURN_UNSUPPORTED Setting the memory encryption attribute
is not supported
- **/
+**/
RETURN_STATUS
EFIAPI
MemEncryptSevSetPageEncMask (
|