OvmfPkg: Update PlatformPei to support Tdx guest

RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429

OvmfPkg/PlatformPei is updated to support Tdx guest. There are below
major changes.
 - Set Tdx related PCDs
 - Publish Tdx RamRegions

In this patch there is another new function BuildPlatformInfoHob ().
This function builds EFI_HOB_PLATFORM_INFO which contains the
HostBridgeDevId. The hob is built in both Td guest and Non-Td guest.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Erdem Aktas <erdemaktas@google.com>
Cc: James Bottomley <jejb@linux.ibm.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
Signed-off-by: Min Xu <min.m.xu@intel.com>

6 files changed, 103 insertions, 3 deletions

diff --git a/OvmfPkg/PlatformPei/FeatureControl.c b/OvmfPkg/PlatformPei/FeatureControl.c
index 9af58c2655..5864ee0c21 100644
--- a/OvmfPkg/PlatformPei/FeatureControl.c
+++ b/OvmfPkg/PlatformPei/FeatureControl.c
@@ -12,6 +12,7 @@
 #include <Library/QemuFwCfgLib.h>

 #include <Ppi/MpServices.h>

 #include <Register/ArchitecturalMsr.h>

+#include <IndustryStandard/Tdx.h>

 

 #include "Platform.h"

 

@@ -37,7 +38,11 @@ WriteFeatureControl (
   IN OUT VOID  *WorkSpace

   )

 {

-  AsmWriteMsr64 (MSR_IA32_FEATURE_CONTROL, mFeatureControlValue);

+  if (TdIsEnabled ()) {

+    TdVmCall (TDVMCALL_WRMSR, (UINT64)MSR_IA32_FEATURE_CONTROL, mFeatureControlValue, 0, 0, 0);

+  } else {

+    AsmWriteMsr64 (MSR_IA32_FEATURE_CONTROL, mFeatureControlValue);

+  }

 }

 

 /**

diff --git a/OvmfPkg/PlatformPei/IntelTdx.c b/OvmfPkg/PlatformPei/IntelTdx.c
new file mode 100644
index 0000000000..3c1ddbfafd
--- /dev/null
+++ b/OvmfPkg/PlatformPei/IntelTdx.c
@@ -0,0 +1,51 @@
+/** @file

+  Initialize Intel TDX support.

+

+  Copyright (c) 2021, Intel Corporation. All rights reserved.<BR>

+

+  SPDX-License-Identifier: BSD-2-Clause-Patent

+

+**/

+

+#include <PiPei.h>

+#include <Library/BaseLib.h>

+#include <Library/DebugLib.h>

+#include <Library/HobLib.h>

+#include <Library/BaseMemoryLib.h>

+#include <Library/MemoryAllocationLib.h>

+#include <IndustryStandard/Tdx.h>

+#include <IndustryStandard/QemuFwCfg.h>

+#include <Library/QemuFwCfgLib.h>

+#include <Library/PeiServicesLib.h>

+#include <Library/TdxLib.h>

+#include <Library/PlatformInitLib.h>

+#include <WorkArea.h>

+#include <ConfidentialComputingGuestAttr.h>

+#include "Platform.h"

+

+/**

+  This Function checks if TDX is available, if present then it sets

+  the dynamic PCDs for Tdx guest.

+  **/

+VOID

+IntelTdxInitialize (

+  VOID

+  )

+{

+ #ifdef MDE_CPU_X64

+  RETURN_STATUS  PcdStatus;

+

+  if (!TdIsEnabled ()) {

+    return;

+  }

+

+  PcdStatus = PcdSet64S (PcdConfidentialComputingGuestAttr, CCAttrIntelTdx);

+  ASSERT_RETURN_ERROR (PcdStatus);

+

+  PcdStatus = PcdSet64S (PcdTdxSharedBitMask, TdSharedPageMask ());

+  ASSERT_RETURN_ERROR (PcdStatus);

+

+  PcdStatus = PcdSetBoolS (PcdSetNxForStack, TRUE);

+  ASSERT_RETURN_ERROR (PcdStatus);

+ #endif

+}

diff --git a/OvmfPkg/PlatformPei/MemDetect.c b/OvmfPkg/PlatformPei/MemDetect.c
index 61d7d3059f..2e47b13229 100644
--- a/OvmfPkg/PlatformPei/MemDetect.c
+++ b/OvmfPkg/PlatformPei/MemDetect.c
@@ -37,7 +37,6 @@ Module Name:
 

 #include <Library/QemuFwCfgLib.h>

 #include <Library/QemuFwCfgSimpleParserLib.h>

-

 #include "Platform.h"

 

 VOID

@@ -231,7 +230,12 @@ GetPeiMemoryCap (
     PdpEntries  = 1 << (mPlatformInfoHob.PhysMemAddressWidth - 30);

     ASSERT (PdpEntries <= 0x200);

   } else {

-    Pml4Entries = 1 << (mPlatformInfoHob.PhysMemAddressWidth - 39);

+    if (mPlatformInfoHob.PhysMemAddressWidth > 48) {

+      Pml4Entries = 0x200;

+    } else {

+      Pml4Entries = 1 << (mPlatformInfoHob.PhysMemAddressWidth - 39);

+    }

+

     ASSERT (Pml4Entries <= 0x200);

     PdpEntries = 512;

   }

@@ -354,6 +358,11 @@ InitializeRamRegions (
   IN EFI_HOB_PLATFORM_INFO  *PlatformInfoHob

   )

 {

+  if (TdIsEnabled ()) {

+    PlatformTdxPublishRamRegions ();

+    return;

+  }

+

   PlatformQemuInitializeRam (PlatformInfoHob);

 

   SevInitializeRam ();

diff --git a/OvmfPkg/PlatformPei/Platform.c b/OvmfPkg/PlatformPei/Platform.c
index f05aec599f..f006755d5f 100644
--- a/OvmfPkg/PlatformPei/Platform.c
+++ b/OvmfPkg/PlatformPei/Platform.c
@@ -311,6 +311,17 @@ MaxCpuCountInitialization (
 }

 

 /**

+ * @brief Builds PlatformInfo Hob

+ */

+VOID

+BuildPlatformInfoHob (

+  VOID

+  )

+{

+  BuildGuidDataHob (&gUefiOvmfPkgPlatformInfoGuid, &mPlatformInfoHob, sizeof (EFI_HOB_PLATFORM_INFO));

+}

+

+/**

   Perform Platform PEI initialization.

 

   @param  FileHandle      Handle of the file being invoked.

@@ -386,7 +397,9 @@ InitializePlatform (
     MiscInitialization (&mPlatformInfoHob);

   }

 

+  IntelTdxInitialize ();

   InstallFeatureControlCallback ();

+  BuildPlatformInfoHob ();

 

   return EFI_SUCCESS;

 }

diff --git a/OvmfPkg/PlatformPei/Platform.h b/OvmfPkg/PlatformPei/Platform.h
index 3d14889340..29b51b2deb 100644
--- a/OvmfPkg/PlatformPei/Platform.h
+++ b/OvmfPkg/PlatformPei/Platform.h
@@ -11,6 +11,7 @@
 

 #include <IndustryStandard/E820.h>

 #include <Library/PlatformInitLib.h>

+#include <IndustryStandard/IntelTdx.h>

 

 extern EFI_HOB_PLATFORM_INFO  mPlatformInfoHob;

 

@@ -84,6 +85,24 @@ AmdSevInitialize (
   VOID

   );

 

+/**

+  This Function checks if TDX is available, if present then it sets

+  the dynamic PCDs for Tdx guest. It also builds Guid hob which contains

+  the Host Bridge DevId.

+  **/

+VOID

+IntelTdxInitialize (

+  VOID

+  );

+

+/**

+ * @brief Builds PlatformInfo Hob

+ */

+VOID

+BuildPlatformInfoHob (

+  VOID

+  );

+

 VOID

 SevInitializeRam (

   VOID

diff --git a/OvmfPkg/PlatformPei/PlatformPei.inf b/OvmfPkg/PlatformPei/PlatformPei.inf
index f6bfc09c2d..00372fa0eb 100644
--- a/OvmfPkg/PlatformPei/PlatformPei.inf
+++ b/OvmfPkg/PlatformPei/PlatformPei.inf
@@ -31,6 +31,7 @@
   MemTypeInfo.c

   Platform.c

   Platform.h

+  IntelTdx.c

 

 [Packages]

   EmbeddedPkg/EmbeddedPkg.dec

@@ -43,6 +44,7 @@
 [Guids]

   gEfiMemoryTypeInformationGuid

   gFdtHobGuid

+  gUefiOvmfPkgPlatformInfoGuid

 

 [LibraryClasses]

   BaseLib

@@ -111,6 +113,7 @@
   gUefiCpuPkgTokenSpaceGuid.PcdSevEsIsEnabled

   gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr

   gUefiCpuPkgTokenSpaceGuid.PcdGhcbHypervisorFeatures

+  gEfiMdeModulePkgTokenSpaceGuid.PcdTdxSharedBitMask

 

 [FixedPcd]

   gUefiOvmfPkgTokenSpaceGuid.PcdOvmfCpuidBase