diff options
| author | Laszlo Ersek <lersek@redhat.com> | 2017-05-18 14:48:13 +0200 |
|---|---|---|
| committer | Laszlo Ersek <lersek@redhat.com> | 2017-05-18 23:38:45 +0200 |
| commit | 38292c08728d10c141a69b05bbdb3afc2c6618e6 (patch) | |
| tree | ba77aebc062acacb446e16e9356ffbda2be427f4 /OvmfPkg/QemuFlashFvbServicesRuntimeDxe | |
| parent | 9c4eef656fa3ea455125abc66780942780b46f85 (diff) | |
| download | edk2-38292c08728d10c141a69b05bbdb3afc2c6618e6.tar.gz edk2-38292c08728d10c141a69b05bbdb3afc2c6618e6.tar.bz2 edk2-38292c08728d10c141a69b05bbdb3afc2c6618e6.zip | |
OvmfPkg/QemuFlashFvbServicesRuntimeDxe: correct NumOfLba vararg type in EraseBlocks()
According to the PI spec, Volume 3,
EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.EraseBlocks():
> The variable argument list is a list of tuples. Each tuple describes a
> range of LBAs to erase and consists of the following:
> * An EFI_LBA that indicates the starting LBA
> * A UINTN that indicates the number of blocks to erase
(NB, in edk2, EFI_FIRMWARE_VOLUME_BLOCK_PROTOCOL is a typedef to
EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.)
In this driver, the NumOfLba local variable is defined with type UINTN,
but the TYPE argument passed to VA_ARG() is UINT32. Fix the mismatch.
Cc: Jordan Justen <jordan.l.justen@intel.com>
Reported-by: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Diffstat (limited to 'OvmfPkg/QemuFlashFvbServicesRuntimeDxe')
| -rw-r--r-- | OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c index ff27c1100c..558b395dff 100644 --- a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c +++ b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FwBlockService.c @@ -645,7 +645,7 @@ FvbProtocolEraseBlocks ( break;
}
- NumOfLba = VA_ARG (args, UINT32);
+ NumOfLba = VA_ARG (args, UINTN);
//
// Check input parameters
@@ -665,7 +665,7 @@ FvbProtocolEraseBlocks ( break;
}
- NumOfLba = VA_ARG (args, UINT32);
+ NumOfLba = VA_ARG (args, UINTN);
while (NumOfLba > 0) {
Status = QemuFlashEraseBlock (StartingLba);
|