diff options
| author | Laszlo Ersek <lersek@redhat.com> | 2014-03-03 08:40:59 +0000 |
|---|---|---|
| committer | jljusten <jljusten@6f19259b-4bc3-4df7-8a09-765794883524> | 2014-03-03 08:40:59 +0000 |
| commit | cd1526101469cb639c7166c0b750c5ebb810a446 (patch) | |
| tree | 9a512eff25a7f7a23cf35928595820ae3c19932d /OvmfPkg/QemuVideoDxe/Qemu.h | |
| parent | 96b5f3977773b71702f67d99f5b758c1a184d2bf (diff) | |
| download | edk2-cd1526101469cb639c7166c0b750c5ebb810a446.tar.gz edk2-cd1526101469cb639c7166c0b750c5ebb810a446.tar.bz2 edk2-cd1526101469cb639c7166c0b750c5ebb810a446.zip | |
OvmfPkg: QemuVideoDxe: clarify QEMU_VIDEO_MODE_DATA.ModeNumber
The field name "ModeNumber" in QEMU_VIDEO_MODE_DATA is misleading -- it is
not immediately obvious whether this field carries a client-visible mode
number, in the GOP sense, or an internal, card type specific mode index.
After checking all references, rename the field to "InternalModeIndex".
Also, when filling in the card type independent QEMU_VIDEO_MODE_DATA array
from the card type specific mode array, distinguish the GOP mode number
from the internal mode index in the debug message.
This patch effects no functional changes.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@15287 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'OvmfPkg/QemuVideoDxe/Qemu.h')
| -rw-r--r-- | OvmfPkg/QemuVideoDxe/Qemu.h | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/OvmfPkg/QemuVideoDxe/Qemu.h b/OvmfPkg/QemuVideoDxe/Qemu.h index 78e182e6bf..098ee774e0 100644 --- a/OvmfPkg/QemuVideoDxe/Qemu.h +++ b/OvmfPkg/QemuVideoDxe/Qemu.h @@ -50,7 +50,7 @@ // QEMU Vide Graphical Mode Data
//
typedef struct {
- UINT32 ModeNumber;
+ UINT32 InternalModeIndex; // points into card-specific mode table
UINT32 HorizontalResolution;
UINT32 VerticalResolution;
UINT32 ColorDepth;
@@ -107,15 +107,22 @@ typedef struct { UINT64 OriginalPciAttributes;
EFI_GRAPHICS_OUTPUT_PROTOCOL GraphicsOutput;
EFI_DEVICE_PATH_PROTOCOL *GopDevicePath;
+
+ //
+ // The next three fields match the client-visible
+ // EFI_GRAPHICS_OUTPUT_PROTOCOL_MODE.Mode and
+ // EFI_GRAPHICS_OUTPUT_PROTOCOL_MODE.MaxMode fields.
+ //
UINTN CurrentMode;
UINTN MaxMode;
QEMU_VIDEO_MODE_DATA *ModeData;
+
UINT8 *LineBuffer;
QEMU_VIDEO_VARIANT Variant;
} QEMU_VIDEO_PRIVATE_DATA;
///
-/// Video Mode structure
+/// Card-specific Video Mode structures
///
typedef struct {
UINT32 Width;
|