diff options
author | Laszlo Ersek <lersek@redhat.com> | 2021-05-26 22:14:39 +0200 |
---|---|---|
committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2021-06-04 16:01:50 +0000 |
commit | 7e25086a0076fcf2bc2cbef01995f034215c209f (patch) | |
tree | e51397d2127b44526216dd9dca49a2254800b5f2 /OvmfPkg/SmbiosPlatformDxe/Qemu.c | |
parent | 8af38170b5c96cff63ee653fe38038466d2c7293 (diff) | |
download | edk2-7e25086a0076fcf2bc2cbef01995f034215c209f.tar.gz edk2-7e25086a0076fcf2bc2cbef01995f034215c209f.tar.bz2 edk2-7e25086a0076fcf2bc2cbef01995f034215c209f.zip |
OvmfPkg/SmbiosPlatformDxe: clean up #includes and INF
- Sort all sections in the INF file.
- Remove unused packages (MdeModulePkg) and lib classes (BaseMemoryLib)
from the INF file.
- Restrict some lib classes (BaseLib, HobLib) and GUIDs (gEfiXenInfoGuid)
to IA32 and X64, in the INF file; only the IA32/X64 Xen implementation
requires these.
- Don't make "SmbiosPlatformDxe.h" #include everything just as a
convenience. Spell out directly needed #includes in every file (annotate
each with an example identifier consumed), drop unused #includes.
- Keep #includes sorted.
- Remove the leading underscore from the #include guard macro name in
"SmbiosPlatformDxe.h".
Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Julien Grall <julien@xen.org>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Message-Id: <20210526201446.12554-37-lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'OvmfPkg/SmbiosPlatformDxe/Qemu.c')
-rw-r--r-- | OvmfPkg/SmbiosPlatformDxe/Qemu.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/OvmfPkg/SmbiosPlatformDxe/Qemu.c b/OvmfPkg/SmbiosPlatformDxe/Qemu.c index e346582381..fcfc3e33c2 100644 --- a/OvmfPkg/SmbiosPlatformDxe/Qemu.c +++ b/OvmfPkg/SmbiosPlatformDxe/Qemu.c @@ -6,10 +6,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
**/
+#include <Library/DebugLib.h> // ASSERT_EFI_ERROR()
+#include <Library/MemoryAllocationLib.h> // AllocatePool()
+#include <Library/PcdLib.h> // PcdGetBool()
+#include <Library/QemuFwCfgLib.h> // QemuFwCfgFindFile()
+
#include "SmbiosPlatformDxe.h"
-#include <Library/QemuFwCfgLib.h>
-#include <Library/MemoryAllocationLib.h>
-#include <Library/PcdLib.h>
/**
Locates and extracts the QEMU SMBIOS data if present in fw_cfg
|