summaryrefslogtreecommitdiffstats
path: root/OvmfPkg/SmmAccess/SmmAccessPei.inf
diff options
context:
space:
mode:
authorLaszlo Ersek <lersek@redhat.com>2017-07-04 13:16:39 +0200
committerLaszlo Ersek <lersek@redhat.com>2017-07-05 22:25:03 +0200
commit1372f8d347abc9f69c6342a1e985ff400d171ac8 (patch)
tree3cb0d679987122e88e0d8dd066032ffc7400d058 /OvmfPkg/SmmAccess/SmmAccessPei.inf
parent23bfb5c0aab6bda348ac03e160d4a8432031fac1 (diff)
downloadedk2-1372f8d347abc9f69c6342a1e985ff400d171ac8.tar.gz
edk2-1372f8d347abc9f69c6342a1e985ff400d171ac8.tar.bz2
edk2-1372f8d347abc9f69c6342a1e985ff400d171ac8.zip
OvmfPkg/SmmAccess: prepare for PcdQ35TsegMbytes becoming dynamic
In one of the next patches we'll turn PcdQ35TsegMbytes into a dynamic PCD, to be set by PlatformPei. Jordan suggested to use gEfiPeiMemoryDiscoveredPpiGuid as SmmAccessPei's DEPEX for making sure that PlatformPei sets the PCD before SmmAccessPei consumes it. (PlatformPei installs the permanent PEI RAM.) Such a DEPEX is supposed to mirror physical firmware, where anything related to SMRAM cannot run before said platform's physical RAM is discovered (signaled by the presence of gEfiPeiMemoryDiscoveredPpiGuid). Introduce the InitQ35TsegMbytes() function and the "mQ35TsegMbytes" extern variable to "SmramInternal.h" and "SmramInternal.c": - Both SmmAccess modules (PEIM and DXE driver) are supposed to call InitQ35TsegMbytes() in their respective entry point functions, saving PcdQ35TsegMbytes into "mQ35TsegMbytes". This way dynamic PCD fetches can be kept out of PEI_SMM_ACCESS_PPI and EFI_SMM_ACCESS2_PROTOCOL member functions later (when we add support for extended TSEG size). - We can thus replace the current PcdQ35TsegMbytes fetches in SmmAccessPei's entry point function as well, with reads from "mQ35TsegMbytes". Cc: Jordan Justen <jordan.l.justen@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Diffstat (limited to 'OvmfPkg/SmmAccess/SmmAccessPei.inf')
-rw-r--r--OvmfPkg/SmmAccess/SmmAccessPei.inf4
1 files changed, 2 insertions, 2 deletions
diff --git a/OvmfPkg/SmmAccess/SmmAccessPei.inf b/OvmfPkg/SmmAccess/SmmAccessPei.inf
index 3908b085da..09f3b63446 100644
--- a/OvmfPkg/SmmAccess/SmmAccessPei.inf
+++ b/OvmfPkg/SmmAccess/SmmAccessPei.inf
@@ -59,11 +59,11 @@
[FeaturePcd]
gUefiOvmfPkgTokenSpaceGuid.PcdSmmSmramRequire
-[FixedPcd]
+[Pcd]
gUefiOvmfPkgTokenSpaceGuid.PcdQ35TsegMbytes
[Ppis]
gPeiSmmAccessPpiGuid ## PRODUCES
[Depex]
- TRUE
+ gEfiPeiMemoryDiscoveredPpiGuid