summaryrefslogtreecommitdiffstats
path: root/OvmfPkg/VirtioNetDxe
diff options
context:
space:
mode:
authorLaszlo Ersek <lersek@redhat.com>2019-09-12 23:27:56 +0200
committerLaszlo Ersek <lersek@redhat.com>2019-10-09 09:40:10 +0200
commit19c2a928055897cfe24e6badb8d43516ce377092 (patch)
treeea150235ca6ef81d479ccb0f0a23e594ac386024 /OvmfPkg/VirtioNetDxe
parent2ef0c27cb84c6366702394558c707f6f94b8f647 (diff)
downloadedk2-19c2a928055897cfe24e6badb8d43516ce377092.tar.gz
edk2-19c2a928055897cfe24e6badb8d43516ce377092.tar.bz2
edk2-19c2a928055897cfe24e6badb8d43516ce377092.zip
OvmfPkg/VirtioNetDxe: fix SignalEvent() call
The SignalEvent() boot service takes an EFI_EVENT, not an (EFI_EVENT*). Fix the call in the notification function of "EFI_SIMPLE_NETWORK_PROTOCOL.WaitForPacket". This is an actual bug. The reason it's never been triggered is likely that the "SNP.WaitForPacket" event is rarely waited for by applications -- edk2 itself has zero instances of that, for example. Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Jordan Justen <jordan.l.justen@intel.com> Signed-off-by: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Diffstat (limited to 'OvmfPkg/VirtioNetDxe')
-rw-r--r--OvmfPkg/VirtioNetDxe/Events.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/OvmfPkg/VirtioNetDxe/Events.c b/OvmfPkg/VirtioNetDxe/Events.c
index 620910774b..83e96e5e5d 100644
--- a/OvmfPkg/VirtioNetDxe/Events.c
+++ b/OvmfPkg/VirtioNetDxe/Events.c
@@ -58,7 +58,7 @@ VirtioNetIsPacketAvailable (
MemoryFence ();
if (Dev->RxLastUsed != RxCurUsed) {
- gBS->SignalEvent (&Dev->Snp.WaitForPacket);
+ gBS->SignalEvent (Dev->Snp.WaitForPacket);
}
}