RedfishPkg: RedfishPlatformConfigDxe: reduce memory allocations

It's unclear why the new string is allocated as copy of the original
string if its pointer is stored in an array and the original string
is released immediately after the copy is created. All data allocated
in the same pool.

Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Reviewed-by: Abner Chang <abner.chang@amd.com>

1 files changed, 1 insertions, 3 deletions

diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c
index cbc65ba594..f970e317b3 100644
--- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c
+++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c
@@ -2057,9 +2057,7 @@ RedfishPlatformConfigProtocolGetConfigureLang (
         TmpString = HiiGetRedfishString (StatementRef->Statement->ParentForm->ParentFormset->HiiHandle, FullSchema, StatementRef->Statement->Description);

         ASSERT (TmpString != NULL);

         if (TmpString != NULL) {

-          TmpConfigureLangList[Index] = AllocateCopyPool (StrSize (TmpString), TmpString);

-          ASSERT (TmpConfigureLangList[Index] != NULL);

-          FreePool (TmpString);

+          TmpConfigureLangList[Index] = TmpString;

           ++Index;

         }

       }