diff options
| author | Mike Maslenkin <mike.maslenkin@gmail.com> | 2023-10-09 00:58:04 +0300 |
|---|---|---|
| committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2023-11-30 07:10:34 +0000 |
| commit | ed923afda5180832cb8a6e0f102c8d0aaef3964a (patch) | |
| tree | 82b30d0274f37dd27c80bc48da6be0c81068c14a /RedfishPkg | |
| parent | 59b6b5059b90883abfcbd906c411e8f59ac1aa0d (diff) | |
| download | edk2-ed923afda5180832cb8a6e0f102c8d0aaef3964a.tar.gz edk2-ed923afda5180832cb8a6e0f102c8d0aaef3964a.tar.bz2 edk2-ed923afda5180832cb8a6e0f102c8d0aaef3964a.zip | |
RedfishPkg: fix memory leak in HiiUtilityLib
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Reviewed-by: Nickle Wang <nicklew@nvidia.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Diffstat (limited to 'RedfishPkg')
| -rw-r--r-- | RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c index 168b445984..fd322c2086 100644 --- a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c +++ b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c @@ -388,11 +388,13 @@ SetQuestionValue ( Question->Value.BufferLen = Question->StorageWidth;
Question->Value.Buffer = AllocateZeroPool (Question->StorageWidth);
if (Question->Value.Buffer == NULL) {
+ FreePool (TemString);
return EFI_OUT_OF_RESOURCES;
}
CopyMem (Question->Value.Buffer, TemString, StrSize (TemString));
Src = Question->Value.Buffer;
+ FreePool (TemString);
} else {
CopyMem (&Question->Value.Value, &QuestionValue->Value, sizeof (EFI_IFR_TYPE_VALUE));
Src = (UINT8 *)&Question->Value.Value;
|