summaryrefslogtreecommitdiffstats
path: root/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256
diff options
context:
space:
mode:
authorStar Zeng <star.zeng@intel.com>2018-04-16 16:39:28 +0800
committerStar Zeng <star.zeng@intel.com>2018-04-20 14:28:48 +0800
commitd4ccf26491e231561b85212754f546f036356828 (patch)
tree29ea5bea629c0a3d575097dbda36e0a1d2fa8dab /SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256
parent0f3cd8a92b036071892c827c59d23799ca31fef4 (diff)
downloadedk2-d4ccf26491e231561b85212754f546f036356828.tar.gz
edk2-d4ccf26491e231561b85212754f546f036356828.tar.bz2
edk2-d4ccf26491e231561b85212754f546f036356828.zip
SecurityPkg FmpAuthenticationLibRsa2048Sha256: Remove PCD reference
PcdRsa2048Sha256PublicKeyBuffer is referenced but not used in the library, that makes me a little confusing. Actually, the PublicKeyData should be from the caller of AuthenticateFmpImage() as input parameter, for example EdkiiSystemCapsuleLib. This patch is to remove the PCD reference in this library instance to be aligned with FmpAuthenticationLibPkcs7 that does not reference PcdPkcs7CertBuffer. Cc: Chao Zhang <chao.b.zhang@intel.com> Cc: Jiewen Yao <jiewen.yao@intel.com> Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng <star.zeng@intel.com> Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
Diffstat (limited to 'SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256')
-rw-r--r--SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.c4
-rw-r--r--SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.inf5
2 files changed, 3 insertions, 6 deletions
diff --git a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.c b/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.c
index b40993fd1b..038e124477 100644
--- a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.c
+++ b/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.c
@@ -10,7 +10,7 @@
FmpAuthenticatedHandlerRsa2048Sha256(), AuthenticateFmpImage() will receive
untrusted input and do basic validation.
- Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD License
which accompanies this distribution. The full text of the license may be found at
@@ -133,7 +133,7 @@ FmpAuthenticatedHandlerRsa2048Sha256 (
}
//
- // Fail if the PublicKey is not one of the public keys in PcdRsa2048Sha256PublicKeyBuffer
+ // Fail if the PublicKey is not one of the public keys in the input PublicKeyData.
//
PublicKey = (VOID *)PublicKeyData;
PublicKeyBufferSize = PublicKeyDataLength;
diff --git a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.inf b/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.inf
index b190eca880..cdd22429c2 100644
--- a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.inf
+++ b/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.inf
@@ -3,7 +3,7 @@
#
# Instance of FmpAuthentication Library for DXE/PEI post memory phase.
#
-# Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.<BR>
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
# which accompanies this distribution. The full text of the license may be found at
@@ -45,9 +45,6 @@
MemoryAllocationLib
BaseCryptLib
-[Pcd]
- gEfiSecurityPkgTokenSpaceGuid.PcdRsa2048Sha256PublicKeyBuffer ## CONSUMES
-
[Guids]
gEfiCertTypeRsa2048Sha256Guid ## SOMETIMES_CONSUMES ## GUID # Unique ID for the type of the certificate.
gEfiHashAlgorithmSha256Guid ## SOMETIMES_CONSUMES ## GUID