diff options
| author | Laszlo Ersek <lersek@redhat.com> | 2018-07-18 19:38:40 +0200 |
|---|---|---|
| committer | Laszlo Ersek <lersek@redhat.com> | 2018-08-16 20:02:50 +0200 |
| commit | 9f5d1f7c316065fcc7eee86d11f9015728b0ca85 (patch) | |
| tree | bbed8b48d60ad5de4cddb63ff2d8d588e0e9cbfe /SecurityPkg/VariableAuthenticated | |
| parent | 5b080845a18fd6375bffc6837148534ddcc49f33 (diff) | |
| download | edk2-9f5d1f7c316065fcc7eee86d11f9015728b0ca85.tar.gz edk2-9f5d1f7c316065fcc7eee86d11f9015728b0ca85.tar.bz2 edk2-9f5d1f7c316065fcc7eee86d11f9015728b0ca85.zip | |
NetworkPkg/TlsAuthConfigDxe: replace OpenFileByDevicePath() with UefiLib API
Replace the OpenFileByDevicePath() function with EfiOpenFileByDevicePath()
from UefiLib, correcting the following issues:
- imprecise comments on OpenFileByDevicePath(),
- code duplication between this module and other modules,
- local variable name "EfiSimpleFileSystemProtocol" starting with "Efi"
prefix,
- bogus "FileHandle = NULL" assignments,
- passing a potentially unaligned "FILEPATH_DEVICE_PATH.PathName" field to
a protocol member function (forbidden by the UEFI spec),
- leaking "Handle1" when the device path type/subtype check fails in the
loop,
- stale SHELL_FILE_HANDLE reference in a comment.
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1008
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Diffstat (limited to 'SecurityPkg/VariableAuthenticated')
0 files changed, 0 insertions, 0 deletions