diff options
| author | Laszlo Ersek <lersek@redhat.com> | 2018-07-18 20:25:25 +0200 |
|---|---|---|
| committer | Laszlo Ersek <lersek@redhat.com> | 2018-08-16 20:02:50 +0200 |
| commit | 15d8fe1fee188cd7a9ce1b0e32cbe34cc93f1097 (patch) | |
| tree | a3539f7e50d27e10ff5e04eeddf31dc1d758a1e7 /ShellPkg/Include/Library | |
| parent | 1bf5007428f741857eaefbacfb6762ce5ea8120d (diff) | |
| download | edk2-15d8fe1fee188cd7a9ce1b0e32cbe34cc93f1097.tar.gz edk2-15d8fe1fee188cd7a9ce1b0e32cbe34cc93f1097.tar.bz2 edk2-15d8fe1fee188cd7a9ce1b0e32cbe34cc93f1097.zip | |
ShellPkg/UefiShellLib: drop DeviceHandle param of ShellOpenFileByDevicePath()
The ShellOpenFileByDevicePath() API promises to set the DeviceHandle
output parameter to the handle of the filesystem identified by the
FilePath input parameter. However, this doesn't actually happen when the
UEFI Shell 2.0 method is used (which is basically "always" nowadays).
Accordingly, the only caller of ShellOpenFileByDevicePath(), namely
ShellOpenFileByName(), defines a (dummy) local DeviceHandle variable just
so it can call ShellOpenFileByDevicePath().
Remove the useless output parameter.
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1008
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Diffstat (limited to 'ShellPkg/Include/Library')
| -rw-r--r-- | ShellPkg/Include/Library/ShellLib.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/ShellPkg/Include/Library/ShellLib.h b/ShellPkg/Include/Library/ShellLib.h index e360a67ac7..92fddc50f5 100644 --- a/ShellPkg/Include/Library/ShellLib.h +++ b/ShellPkg/Include/Library/ShellLib.h @@ -89,7 +89,6 @@ ShellSetFileInfo ( @param[in, out] FilePath On input, the device path to the file. On output,
the remaining device path.
- @param[out] DeviceHandle Pointer to the system device handle.
@param[out] FileHandle Pointer to the file handle.
@param[in] OpenMode The mode to open the file with.
@param[in] Attributes The file's file attributes.
@@ -115,7 +114,6 @@ EFI_STATUS EFIAPI
ShellOpenFileByDevicePath(
IN OUT EFI_DEVICE_PATH_PROTOCOL **FilePath,
- OUT EFI_HANDLE *DeviceHandle,
OUT SHELL_FILE_HANDLE *FileHandle,
IN UINT64 OpenMode,
IN UINT64 Attributes
|