ShellPkg: acpiview: RSDP: Make code consistent with other parsers

List ParseAcpi() function arguments one per line in order to make this
function call consistent with ParseAcpi() calls in other ACPI table
parsers.

Also, notify the user that XsdtAddress value of 0 results in RSDP
parsing being terminated and that the XSDT table will not be processed.

This effectively means that no more ACPI tables will be parsed because
of this RSDP table content error.

Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

1 files changed, 9 insertions, 2 deletions

diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c
index 4bf928139a..5a5c4b50c1 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c
@@ -129,7 +129,14 @@ ParseAcpiRsdp (
     VerifyChecksum (TRUE, Ptr, AcpiTableLength);

   }

 

-  ParseAcpi (Trace, 0, "RSDP", Ptr, AcpiTableLength, PARSER_PARAMS (RsdpParser));

+  ParseAcpi (

+    Trace,

+    0,

+    "RSDP",

+    Ptr,

+    AcpiTableLength,

+    PARSER_PARAMS (RsdpParser)

+    );

 

   // This code currently supports parsing of XSDT table only

   // and does not parse the RSDT table. Platforms provide the

@@ -137,7 +144,7 @@ ParseAcpiRsdp (
   // Therefore the RSDT should not be used on ARM platforms.

   if ((*XsdtAddress) == 0) {

     IncrementErrorCount ();

-    Print (L"ERROR: XSDT Pointer is not set.\n");

+    Print (L"ERROR: XSDT Pointer is not set. RSDP parsing aborted.\n");

     return;

   }