diff options
| author | Bret Barkelew <Bret.Barkelew@microsoft.com> | 2019-06-12 14:04:57 +0800 |
|---|---|---|
| committer | Jaben Carsey <jaben.carsey@intel.com> | 2019-07-01 09:47:16 -0700 |
| commit | 21902410ad87aadd3a68ec7ecb4ee11594d9fcb0 (patch) | |
| tree | 09e3e39e814fed10358f0e38d25335acc29d851a /ShellPkg/Library/UefiShellLib/UefiShellLib.c | |
| parent | 6a1f06fadb26c342205cf9edeba7e67e92e2135b (diff) | |
| download | edk2-21902410ad87aadd3a68ec7ecb4ee11594d9fcb0.tar.gz edk2-21902410ad87aadd3a68ec7ecb4ee11594d9fcb0.tar.bz2 edk2-21902410ad87aadd3a68ec7ecb4ee11594d9fcb0.zip | |
ShellPkg/UefiShellLib: Set input pointer parameter to null if failure
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1906
While failed to allocate memory to save the response,
set the input/output parameter 'Response'(VOID **) to
NULL to indicate the failure not only depend on the
returned status.
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Turner <Michael.Turner@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
Diffstat (limited to 'ShellPkg/Library/UefiShellLib/UefiShellLib.c')
| -rw-r--r-- | ShellPkg/Library/UefiShellLib/UefiShellLib.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c b/ShellPkg/Library/UefiShellLib/UefiShellLib.c index 430b20e127..5be530092e 100644 --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c @@ -3366,6 +3366,9 @@ ShellPromptForResponse ( if (Type != ShellPromptResponseTypeFreeform) {
Resp = (SHELL_PROMPT_RESPONSE*)AllocateZeroPool(sizeof(SHELL_PROMPT_RESPONSE));
if (Resp == NULL) {
+ if (Response != NULL) {
+ *Response = NULL;
+ }
return (EFI_OUT_OF_RESOURCES);
}
}
@@ -3568,6 +3571,8 @@ ShellPromptForResponse ( *Response = Resp;
} else if (Buffer != NULL) {
*Response = Buffer;
+ } else {
+ *Response = NULL;
}
} else {
if (Resp != NULL) {
|