diff options
| author | Laszlo Ersek <lersek@redhat.com> | 2018-02-12 14:03:44 +0100 |
|---|---|---|
| committer | Laszlo Ersek <lersek@redhat.com> | 2018-02-13 13:29:35 +0100 |
| commit | 7a141b1306f61c1cf92847d3d2743f4f57965227 (patch) | |
| tree | 3203c2b425fd4352cb2f30223c55a861f4118c15 /ShellPkg/ShellPkg.dsc | |
| parent | bad0b5e8716513dd0dc3e5b07e8c672b2e366486 (diff) | |
| download | edk2-7a141b1306f61c1cf92847d3d2743f4f57965227.tar.gz edk2-7a141b1306f61c1cf92847d3d2743f4f57965227.tar.bz2 edk2-7a141b1306f61c1cf92847d3d2743f4f57965227.zip | |
ShellPkg: remove superfluous TimerLib resolution
TimerLib had to be resolved in commit 5ab97a64b51c ("ShellPkg/bcfg: Add
Shell Spec 2.2 modification functionality", 2017-03-01) because:
- the BCFG command started making calls to UefiBootManagerLib
(EfiBootManagerVariableToLoadOption(),
EfiBootManagerLoadOptionToVariable(), EfiBootManagerFreeLoadOption()),
- and "MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf"
depended on TimerLib.
Because TimerLib is platform-specific, but "ShellPkg/ShellPkg.dsc" is
meant to produce a UEFI shell binary that is platform-independent (see
"ShellBinPkg/ReadMe.txt"), we resolved TimerLib to
"BaseTimerLibNullTemplate.inf". (TimerLib functionality was never actually
needed on UefiBootManagerLib code paths that were exercised by the shell /
BCFG.)
Thanks to the last patch, UefiBootManagerLib no longer depends on
TimerLib, thus we can drop the TimerLib resolution entirely.
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Diffstat (limited to 'ShellPkg/ShellPkg.dsc')
| -rw-r--r-- | ShellPkg/ShellPkg.dsc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc index 29f5376412..1c923f5851 100644 --- a/ShellPkg/ShellPkg.dsc +++ b/ShellPkg/ShellPkg.dsc @@ -58,7 +58,6 @@ UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
- TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf
PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLibNull.inf
DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
|