summaryrefslogtreecommitdiffstats
path: root/ShellPkg
diff options
context:
space:
mode:
authorLaszlo Ersek <lersek@redhat.com>2016-10-18 12:53:48 +0200
committerLaszlo Ersek <lersek@redhat.com>2016-10-18 19:30:38 +0200
commit09bd67f09573ad5a40875f3d7bfbf49c43756cf5 (patch)
treed0af6e74fc8bec6cac56777f1321302dc032cd6e /ShellPkg
parentbfa97024df7c0c4bd94157a1e9c3eb5e89cba656 (diff)
downloadedk2-09bd67f09573ad5a40875f3d7bfbf49c43756cf5.tar.gz
edk2-09bd67f09573ad5a40875f3d7bfbf49c43756cf5.tar.bz2
edk2-09bd67f09573ad5a40875f3d7bfbf49c43756cf5.zip
ShellPkg/Shell: fix CopyGuid() arg order in EfiShellGetGuidFromName()
The destination GUID comes first; from "MdePkg/Include/Library/BaseMemoryLib.h": > GUID * > EFIAPI > CopyGuid ( > OUT GUID *DestinationGuid, > IN CONST GUID *SourceGuid > ); Here "NewGuid" is the GUID looked up by GetGuidFromStringName(), and "Guid" is where EfiShellGetGuidFromName() has to propagate that result to. Cc: Jaben Carsey <jaben.carsey@intel.com> Cc: Ruiyu Ni <ruiyu.ni@intel.com> Cc: Tim Lewis <tim.lewis@insyde.com> Reported-by: Tim Lewis <tim.lewis@insyde.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <lersek@redhat.com> Reviewed-by: Tim Lewis <tim.lewis@insyde.com> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Diffstat (limited to 'ShellPkg')
-rw-r--r--ShellPkg/Application/Shell/ShellProtocol.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/ShellPkg/Application/Shell/ShellProtocol.c b/ShellPkg/Application/Shell/ShellProtocol.c
index 2bc0646b45..04b66c5aca 100644
--- a/ShellPkg/Application/Shell/ShellProtocol.c
+++ b/ShellPkg/Application/Shell/ShellProtocol.c
@@ -2207,7 +2207,7 @@ EfiShellGetGuidFromName(
Status = GetGuidFromStringName(GuidName, NULL, &NewGuid);
if (!EFI_ERROR(Status)) {
- CopyGuid(NewGuid, Guid);
+ CopyGuid(Guid, NewGuid);
}
return (Status);