StandaloneMmPkg: Fix ECC error 3002 in StandaloneMmCpu

Bugzilla: 3150 (https://bugzilla.tianocore.org/show_bug.cgi?id=3150)

Fix the ECC tool reported error "[3002] Non-Boolean comparisons
should use a compare operator".

Also fix the following:
 - add curly braces for 'if' condition statements to comply
   with the coding standard.
 - The value returned by GET_GUID_HOB_DATA() is stored in
   *HobData. Therefore, check *HobData against NULL. The
   original code was checking HobData which is incorrect.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
Acked-by: Jiewen Yao <Jiewen.yao@intel.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

1 files changed, 7 insertions, 4 deletions

diff --git a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c
index 617babd5ab..9e49609601 100644
--- a/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c
+++ b/StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c
@@ -2,7 +2,7 @@
 

   Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<BR>

   Copyright (c) 2016 HP Development Company, L.P.

-  Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.

+  Copyright (c) 2016 - 2021, Arm Limited. All rights reserved.

 

   SPDX-License-Identifier: BSD-2-Clause-Patent

 

@@ -53,16 +53,19 @@ GetGuidedHobData (
 {

   EFI_HOB_GUID_TYPE *Hob;

 

-  if (!HobList || !HobGuid || !HobData)

+  if ((HobList == NULL) || (HobGuid == NULL) || (HobData == NULL)) {

     return EFI_INVALID_PARAMETER;

+  }

 

   Hob = GetNextGuidHob (HobGuid, HobList);

-  if (!Hob)

+  if (Hob == NULL) {

     return EFI_NOT_FOUND;

+  }

 

   *HobData = GET_GUID_HOB_DATA (Hob);

-  if (!HobData)

+  if (*HobData == NULL) {

     return EFI_NOT_FOUND;

+  }

 

   return EFI_SUCCESS;

 }