summaryrefslogtreecommitdiffstats
path: root/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.c
diff options
context:
space:
mode:
authorStar Zeng <star.zeng@intel.com>2019-07-05 13:14:33 +0800
committerEric Dong <eric.dong@intel.com>2019-07-16 16:03:51 +0800
commit84a459472075d94963463bffaa5dc6eee47f14c3 (patch)
treed727d96267e615dbf07e94cb030fee41f9a64e03 /UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.c
parent51dd408ae1022e5c9378492451a62b38d5b101c5 (diff)
downloadedk2-84a459472075d94963463bffaa5dc6eee47f14c3.tar.gz
edk2-84a459472075d94963463bffaa5dc6eee47f14c3.tar.bz2
edk2-84a459472075d94963463bffaa5dc6eee47f14c3.zip
UefiCpuPkg CpuCommonFeaturesLib: Enhance Ppin code
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1961 Enhance Ppin code to enable and unlock for TRUE State, and disable and lock for FALSE State. Note: enable and lock could not be set both. According to SDM, once Enable_PPIN is set, attempt to write 1 to LockOut will cause #GP, and writing 1 to LockOut is permitted only if Enable_PPIN is clear. Cc: Laszlo Ersek <lersek@redhat.com> Cc: Eric Dong <eric.dong@intel.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Chandana Kumar <chandana.c.kumar@intel.com> Cc: Kevin Li <kevin.y.li@intel.com> Signed-off-by: Star Zeng <star.zeng@intel.com> Reviewed-by: Ray Ni <ray.ni@intel.com> Reviewed-by: Eric Dong <eric.dong@intel.com>
Diffstat (limited to 'UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.c')
-rw-r--r--UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.c b/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.c
index 7cc692efb6..fd43b8d662 100644
--- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.c
+++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.c
@@ -203,7 +203,7 @@ CpuCommonFeaturesLibConstructor (
if (IsCpuFeatureSupported (CPU_FEATURE_PPIN)) {
Status = RegisterCpuFeature (
"PPIN",
- NULL,
+ PpinGetConfigData,
PpinSupport,
PpinInitialize,
CPU_FEATURE_PPIN,