summaryrefslogtreecommitdiffstats
path: root/UefiCpuPkg
diff options
context:
space:
mode:
authorJeff Fan <jeff.fan@intel.com>2015-09-01 08:56:14 +0000
committervanjeff <vanjeff@Edk2>2015-09-01 08:56:14 +0000
commit8b4c856c9113f5ab4ca838075fc7d95e105c8417 (patch)
tree30952c6b03a70c7f337247dd542430da32490089 /UefiCpuPkg
parentf1c97bb3f405f43f74866c0a55a15a3f184f83b6 (diff)
downloadedk2-8b4c856c9113f5ab4ca838075fc7d95e105c8417.tar.gz
edk2-8b4c856c9113f5ab4ca838075fc7d95e105c8417.tar.bz2
edk2-8b4c856c9113f5ab4ca838075fc7d95e105c8417.zip
UefiCpuPkg/CpuMpPei: Fix CPU Healthy issue in PeiGetProcessorInfo ()
CPU Healthy state maybe changed by software. We should return Healthy state from Healthy bit instead of from CPU BIST hardware information. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan <jeff.fan@intel.com> Reviewed-by: Feng Tian <feng.tian@intel.com> git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@18374 6f19259b-4bc3-4df7-8a09-765794883524
Diffstat (limited to 'UefiCpuPkg')
-rw-r--r--UefiCpuPkg/CpuMpPei/CpuBist.c5
-rw-r--r--UefiCpuPkg/CpuMpPei/PeiMpServices.c2
2 files changed, 5 insertions, 2 deletions
diff --git a/UefiCpuPkg/CpuMpPei/CpuBist.c b/UefiCpuPkg/CpuMpPei/CpuBist.c
index 2bee7a4a66..56292452a9 100644
--- a/UefiCpuPkg/CpuMpPei/CpuBist.c
+++ b/UefiCpuPkg/CpuMpPei/CpuBist.c
@@ -226,7 +226,10 @@ CollectBistDataFromPpi (
CpuData->Health = CpuInstance[CpuIndex].InfoRecord.IA32HealthFlags;
}
}
- if (CpuData->Health.Uint32 != 0) {
+ if (CpuData->Health.Uint32 == 0) {
+ CpuData->CpuHealthy = TRUE;
+ } else {
+ CpuData->CpuHealthy = FALSE;
//
// Report Status Code that self test is failed
//
diff --git a/UefiCpuPkg/CpuMpPei/PeiMpServices.c b/UefiCpuPkg/CpuMpPei/PeiMpServices.c
index 4215f9e51b..5dd2c153f4 100644
--- a/UefiCpuPkg/CpuMpPei/PeiMpServices.c
+++ b/UefiCpuPkg/CpuMpPei/PeiMpServices.c
@@ -334,7 +334,7 @@ PeiGetProcessorInfo (
if (PeiCpuMpData->CpuData[ProcessorNumber].ApicId == GetInitialApicId()) {
ProcessorInfoBuffer->StatusFlag |= PROCESSOR_AS_BSP_BIT;
}
- if (PeiCpuMpData->CpuData[ProcessorNumber].Health.Uint32 == 0) {
+ if (PeiCpuMpData->CpuData[ProcessorNumber].CpuHealthy) {
ProcessorInfoBuffer->StatusFlag |= PROCESSOR_HEALTH_STATUS_BIT;
}
if (PeiCpuMpData->CpuData[ProcessorNumber].State == CpuStateDisabled) {