diff options
| author | Hao A Wu <hao.a.wu@intel.com> | 2020-01-16 09:30:12 +0800 |
|---|---|---|
| committer | mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> | 2020-02-11 03:50:54 +0000 |
| commit | d148a178c14babba30f8cfaa724ffc50da258c0a (patch) | |
| tree | aaf241fb35af4a53512f68a3384a6e27eb99a7a4 /UefiCpuPkg | |
| parent | ccb4c38a505cc830625d9ba10622cd910f03490c (diff) | |
| download | edk2-d148a178c14babba30f8cfaa724ffc50da258c0a.tar.gz edk2-d148a178c14babba30f8cfaa724ffc50da258c0a.tar.bz2 edk2-d148a178c14babba30f8cfaa724ffc50da258c0a.zip | |
Revert UefiCpuPkg/MpInitLib: Relocate microcode patch fields in CPU_MP_DATA
This reverts commit 88bd06616617ef2569f093f7b51893c11ad78e26.
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2465
Commit 88bd0661661 relocates the 'MicrocodePatchAddress' and
'MicrocodePatchRegionSize' fields in structure CPU_MP_DATA to ensure that
they can be properly passed between different architectures.
However, such change is not backward compatible with the scenario like
pre-existing binaries such as FSP. These binaries are built when the code
base has a different version of the CPU_MP_DATA structure definition. This
may cause issues when accessing the 'MicrocodePatchAddress' and
'MicrocodePatchRegionSize' fields, since their offsets are different
(between PEI phase in the FSP binaries and DXE phase in current code
implementation).
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
Reviewed-by: Ray Ni <ray.ni@intel.com>
Diffstat (limited to 'UefiCpuPkg')
| -rw-r--r-- | UefiCpuPkg/Library/MpInitLib/MpLib.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h index 7c62d75acc..d7e20f0b74 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h @@ -219,8 +219,6 @@ struct _CPU_MP_DATA { UINT64 CpuInfoInHob;
UINT32 CpuCount;
UINT32 BspNumber;
- UINT64 MicrocodePatchAddress;
- UINT64 MicrocodePatchRegionSize;
//
// The above fields data will be passed from PEI to DXE
// Please make sure the fields offset same in the different
@@ -264,6 +262,8 @@ struct _CPU_MP_DATA { UINT8 Vector;
BOOLEAN PeriodicMode;
BOOLEAN TimerInterruptState;
+ UINT64 MicrocodePatchAddress;
+ UINT64 MicrocodePatchRegionSize;
//
// Whether need to use Init-Sipi-Sipi to wake up the APs.
|