diff options
Diffstat (limited to 'NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c')
| -rw-r--r-- | NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c | 145 |
1 files changed, 69 insertions, 76 deletions
diff --git a/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c b/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c index a795d26247..b19192bfc2 100644 --- a/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c +++ b/NetworkPkg/Mtftp4Dxe/Mtftp4Driver.c @@ -8,7 +8,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include "Mtftp4Impl.h"
-EFI_DRIVER_BINDING_PROTOCOL gMtftp4DriverBinding = {
+EFI_DRIVER_BINDING_PROTOCOL gMtftp4DriverBinding = {
Mtftp4DriverBindingSupported,
Mtftp4DriverBindingStart,
Mtftp4DriverBindingStop,
@@ -22,7 +22,6 @@ EFI_SERVICE_BINDING_PROTOCOL gMtftp4ServiceBindingTemplete = { Mtftp4ServiceBindingDestroyChild
};
-
/**
The driver entry point which installs multiple protocols to the ImageHandle.
@@ -36,8 +35,8 @@ EFI_SERVICE_BINDING_PROTOCOL gMtftp4ServiceBindingTemplete = { EFI_STATUS
EFIAPI
Mtftp4DriverEntryPoint (
- IN EFI_HANDLE ImageHandle,
- IN EFI_SYSTEM_TABLE *SystemTable
+ IN EFI_HANDLE ImageHandle,
+ IN EFI_SYSTEM_TABLE *SystemTable
)
{
return EfiLibInstallDriverBindingComponentName2 (
@@ -50,7 +49,6 @@ Mtftp4DriverEntryPoint ( );
}
-
/**
Test whether MTFTP driver support this controller.
@@ -75,9 +73,9 @@ Mtftp4DriverEntryPoint ( EFI_STATUS
EFIAPI
Mtftp4DriverBindingSupported (
- IN EFI_DRIVER_BINDING_PROTOCOL *This,
- IN EFI_HANDLE Controller,
- IN EFI_DEVICE_PATH_PROTOCOL *RemainingDevicePath
+ IN EFI_DRIVER_BINDING_PROTOCOL *This,
+ IN EFI_HANDLE Controller,
+ IN EFI_DEVICE_PATH_PROTOCOL *RemainingDevicePath
)
{
EFI_STATUS Status;
@@ -94,7 +92,6 @@ Mtftp4DriverBindingSupported ( return Status;
}
-
/**
Config a NULL UDP that is used to keep the connection between UDP and MTFTP.
@@ -110,14 +107,13 @@ Mtftp4DriverBindingSupported ( EFI_STATUS
EFIAPI
Mtftp4ConfigNullUdp (
- IN UDP_IO *UdpIo,
- IN VOID *Context
+ IN UDP_IO *UdpIo,
+ IN VOID *Context
)
{
return EFI_SUCCESS;
}
-
/**
Create then initialize a MTFTP service binding instance.
@@ -136,16 +132,16 @@ Mtftp4ConfigNullUdp ( **/
EFI_STATUS
Mtftp4CreateService (
- IN EFI_HANDLE Controller,
- IN EFI_HANDLE Image,
- OUT MTFTP4_SERVICE **Service
+ IN EFI_HANDLE Controller,
+ IN EFI_HANDLE Image,
+ OUT MTFTP4_SERVICE **Service
)
{
- MTFTP4_SERVICE *MtftpSb;
- EFI_STATUS Status;
+ MTFTP4_SERVICE *MtftpSb;
+ EFI_STATUS Status;
- *Service = NULL;
- MtftpSb = AllocatePool (sizeof (MTFTP4_SERVICE));
+ *Service = NULL;
+ MtftpSb = AllocatePool (sizeof (MTFTP4_SERVICE));
if (MtftpSb == NULL) {
return EFI_OUT_OF_RESOURCES;
@@ -229,7 +225,6 @@ Mtftp4CreateService ( return EFI_SUCCESS;
}
-
/**
Release all the resource used the MTFTP service binding instance.
@@ -238,7 +233,7 @@ Mtftp4CreateService ( **/
VOID
Mtftp4CleanService (
- IN MTFTP4_SERVICE *MtftpSb
+ IN MTFTP4_SERVICE *MtftpSb
)
{
UdpIoFreeIo (MtftpSb->ConnectUdp);
@@ -247,7 +242,6 @@ Mtftp4CleanService ( gBS->CloseEvent (MtftpSb->Timer);
}
-
/**
Start the MTFTP driver on this controller.
@@ -272,8 +266,8 @@ Mtftp4DriverBindingStart ( IN EFI_DEVICE_PATH_PROTOCOL *RemainingDevicePath
)
{
- MTFTP4_SERVICE *MtftpSb;
- EFI_STATUS Status;
+ MTFTP4_SERVICE *MtftpSb;
+ EFI_STATUS Status;
//
// Directly return if driver is already running.
@@ -296,6 +290,7 @@ Mtftp4DriverBindingStart ( if (EFI_ERROR (Status)) {
return Status;
}
+
ASSERT (MtftpSb != NULL);
Status = gBS->SetTimer (MtftpSb->Timer, TimerPeriodic, TICKS_PER_SECOND);
@@ -346,8 +341,8 @@ ON_ERROR: EFI_STATUS
EFIAPI
Mtftp4DestroyChildEntryInHandleBuffer (
- IN LIST_ENTRY *Entry,
- IN VOID *Context
+ IN LIST_ENTRY *Entry,
+ IN VOID *Context
)
{
MTFTP4_PROTOCOL *Instance;
@@ -355,14 +350,14 @@ Mtftp4DestroyChildEntryInHandleBuffer ( UINTN NumberOfChildren;
EFI_HANDLE *ChildHandleBuffer;
- if (Entry == NULL || Context == NULL) {
+ if ((Entry == NULL) || (Context == NULL)) {
return EFI_INVALID_PARAMETER;
}
- Instance = NET_LIST_USER_STRUCT_S (Entry, MTFTP4_PROTOCOL, Link, MTFTP4_PROTOCOL_SIGNATURE);
- ServiceBinding = ((MTFTP4_DESTROY_CHILD_IN_HANDLE_BUF_CONTEXT *) Context)->ServiceBinding;
- NumberOfChildren = ((MTFTP4_DESTROY_CHILD_IN_HANDLE_BUF_CONTEXT *) Context)->NumberOfChildren;
- ChildHandleBuffer = ((MTFTP4_DESTROY_CHILD_IN_HANDLE_BUF_CONTEXT *) Context)->ChildHandleBuffer;
+ Instance = NET_LIST_USER_STRUCT_S (Entry, MTFTP4_PROTOCOL, Link, MTFTP4_PROTOCOL_SIGNATURE);
+ ServiceBinding = ((MTFTP4_DESTROY_CHILD_IN_HANDLE_BUF_CONTEXT *)Context)->ServiceBinding;
+ NumberOfChildren = ((MTFTP4_DESTROY_CHILD_IN_HANDLE_BUF_CONTEXT *)Context)->NumberOfChildren;
+ ChildHandleBuffer = ((MTFTP4_DESTROY_CHILD_IN_HANDLE_BUF_CONTEXT *)Context)->ChildHandleBuffer;
if (!NetIsInHandleBuffer (Instance->Handle, NumberOfChildren, ChildHandleBuffer)) {
return EFI_SUCCESS;
@@ -387,18 +382,18 @@ Mtftp4DestroyChildEntryInHandleBuffer ( EFI_STATUS
EFIAPI
Mtftp4DriverBindingStop (
- IN EFI_DRIVER_BINDING_PROTOCOL *This,
- IN EFI_HANDLE Controller,
- IN UINTN NumberOfChildren,
- IN EFI_HANDLE *ChildHandleBuffer
+ IN EFI_DRIVER_BINDING_PROTOCOL *This,
+ IN EFI_HANDLE Controller,
+ IN UINTN NumberOfChildren,
+ IN EFI_HANDLE *ChildHandleBuffer
)
{
- EFI_SERVICE_BINDING_PROTOCOL *ServiceBinding;
- MTFTP4_SERVICE *MtftpSb;
- EFI_HANDLE NicHandle;
- EFI_STATUS Status;
- LIST_ENTRY *List;
- MTFTP4_DESTROY_CHILD_IN_HANDLE_BUF_CONTEXT Context;
+ EFI_SERVICE_BINDING_PROTOCOL *ServiceBinding;
+ MTFTP4_SERVICE *MtftpSb;
+ EFI_HANDLE NicHandle;
+ EFI_STATUS Status;
+ LIST_ENTRY *List;
+ MTFTP4_DESTROY_CHILD_IN_HANDLE_BUF_CONTEXT Context;
//
// MTFTP driver opens UDP child, So, Controller is a UDP
@@ -414,7 +409,7 @@ Mtftp4DriverBindingStop ( Status = gBS->OpenProtocol (
NicHandle,
&gEfiMtftp4ServiceBindingProtocolGuid,
- (VOID **) &ServiceBinding,
+ (VOID **)&ServiceBinding,
This->DriverBindingHandle,
NicHandle,
EFI_OPEN_PROTOCOL_GET_PROTOCOL
@@ -430,19 +425,19 @@ Mtftp4DriverBindingStop ( //
// Destroy the Mtftp4 child instance in ChildHandleBuffer.
//
- List = &MtftpSb->Children;
+ List = &MtftpSb->Children;
Context.ServiceBinding = ServiceBinding;
Context.NumberOfChildren = NumberOfChildren;
Context.ChildHandleBuffer = ChildHandleBuffer;
- Status = NetDestroyLinkList (
- List,
- Mtftp4DestroyChildEntryInHandleBuffer,
- &Context,
- NULL
- );
+ Status = NetDestroyLinkList (
+ List,
+ Mtftp4DestroyChildEntryInHandleBuffer,
+ &Context,
+ NULL
+ );
}
- if (NumberOfChildren == 0 && IsListEmpty (&MtftpSb->Children)) {
+ if ((NumberOfChildren == 0) && IsListEmpty (&MtftpSb->Children)) {
gBS->UninstallProtocolInterface (
NicHandle,
&gEfiMtftp4ServiceBindingProtocolGuid,
@@ -454,6 +449,7 @@ Mtftp4DriverBindingStop ( FreeUnicodeStringTable (gMtftp4ControllerNameTable);
gMtftp4ControllerNameTable = NULL;
}
+
FreePool (MtftpSb);
Status = EFI_SUCCESS;
@@ -462,7 +458,6 @@ Mtftp4DriverBindingStop ( return Status;
}
-
/**
Initialize a MTFTP protocol instance which is the child of MtftpSb.
@@ -472,8 +467,8 @@ Mtftp4DriverBindingStop ( **/
VOID
Mtftp4InitProtocol (
- IN MTFTP4_SERVICE *MtftpSb,
- OUT MTFTP4_PROTOCOL *Instance
+ IN MTFTP4_SERVICE *MtftpSb,
+ OUT MTFTP4_PROTOCOL *Instance
)
{
ZeroMem (Instance, sizeof (MTFTP4_PROTOCOL));
@@ -481,13 +476,12 @@ Mtftp4InitProtocol ( Instance->Signature = MTFTP4_PROTOCOL_SIGNATURE;
InitializeListHead (&Instance->Link);
CopyMem (&Instance->Mtftp4, &gMtftp4ProtocolTemplate, sizeof (Instance->Mtftp4));
- Instance->State = MTFTP4_STATE_UNCONFIGED;
- Instance->Service = MtftpSb;
+ Instance->State = MTFTP4_STATE_UNCONFIGED;
+ Instance->Service = MtftpSb;
InitializeListHead (&Instance->Blocks);
}
-
/**
Create a MTFTP child for the service binding instance, then
install the MTFTP protocol to the ChildHandle.
@@ -504,14 +498,14 @@ EFI_STATUS EFIAPI
Mtftp4ServiceBindingCreateChild (
IN EFI_SERVICE_BINDING_PROTOCOL *This,
- IN EFI_HANDLE *ChildHandle
+ IN EFI_HANDLE *ChildHandle
)
{
- MTFTP4_SERVICE *MtftpSb;
- MTFTP4_PROTOCOL *Instance;
- EFI_STATUS Status;
- EFI_TPL OldTpl;
- VOID *Udp4;
+ MTFTP4_SERVICE *MtftpSb;
+ MTFTP4_PROTOCOL *Instance;
+ EFI_STATUS Status;
+ EFI_TPL OldTpl;
+ VOID *Udp4;
if ((This == NULL) || (ChildHandle == NULL)) {
return EFI_INVALID_PARAMETER;
@@ -556,7 +550,7 @@ Mtftp4ServiceBindingCreateChild ( return Status;
}
- Instance->Handle = *ChildHandle;
+ Instance->Handle = *ChildHandle;
//
// Open the Udp4 protocol BY_CHILD.
@@ -564,7 +558,7 @@ Mtftp4ServiceBindingCreateChild ( Status = gBS->OpenProtocol (
MtftpSb->ConnectUdp->UdpHandle,
&gEfiUdp4ProtocolGuid,
- (VOID **) &Udp4,
+ (VOID **)&Udp4,
gMtftp4DriverBinding.DriverBindingHandle,
Instance->Handle,
EFI_OPEN_PROTOCOL_BY_CHILD_CONTROLLER
@@ -579,7 +573,7 @@ Mtftp4ServiceBindingCreateChild ( Status = gBS->OpenProtocol (
Instance->UnicastPort->UdpHandle,
&gEfiUdp4ProtocolGuid,
- (VOID **) &Udp4,
+ (VOID **)&Udp4,
gMtftp4DriverBinding.DriverBindingHandle,
Instance->Handle,
EFI_OPEN_PROTOCOL_BY_CHILD_CONTROLLER
@@ -625,7 +619,6 @@ ON_ERROR: return Status;
}
-
/**
Destroy one of the service binding's child.
@@ -641,15 +634,15 @@ ON_ERROR: EFI_STATUS
EFIAPI
Mtftp4ServiceBindingDestroyChild (
- IN EFI_SERVICE_BINDING_PROTOCOL *This,
- IN EFI_HANDLE ChildHandle
+ IN EFI_SERVICE_BINDING_PROTOCOL *This,
+ IN EFI_HANDLE ChildHandle
)
{
- MTFTP4_SERVICE *MtftpSb;
- MTFTP4_PROTOCOL *Instance;
- EFI_MTFTP4_PROTOCOL *Mtftp4;
- EFI_STATUS Status;
- EFI_TPL OldTpl;
+ MTFTP4_SERVICE *MtftpSb;
+ MTFTP4_PROTOCOL *Instance;
+ EFI_MTFTP4_PROTOCOL *Mtftp4;
+ EFI_STATUS Status;
+ EFI_TPL OldTpl;
if ((This == NULL) || (ChildHandle == NULL)) {
return EFI_INVALID_PARAMETER;
@@ -661,7 +654,7 @@ Mtftp4ServiceBindingDestroyChild ( Status = gBS->OpenProtocol (
ChildHandle,
&gEfiMtftp4ProtocolGuid,
- (VOID **) &Mtftp4,
+ (VOID **)&Mtftp4,
gMtftp4DriverBinding.DriverBindingHandle,
ChildHandle,
EFI_OPEN_PROTOCOL_GET_PROTOCOL
@@ -671,8 +664,8 @@ Mtftp4ServiceBindingDestroyChild ( return EFI_UNSUPPORTED;
}
- Instance = MTFTP4_PROTOCOL_FROM_THIS (Mtftp4);
- MtftpSb = MTFTP4_SERVICE_FROM_THIS (This);
+ Instance = MTFTP4_PROTOCOL_FROM_THIS (Mtftp4);
+ MtftpSb = MTFTP4_SERVICE_FROM_THIS (This);
if (Instance->Service != MtftpSb) {
return EFI_INVALID_PARAMETER;
|