diff options
| author | Felix Singer <felixsinger@posteo.net> | 2022-07-29 03:16:19 +0200 |
|---|---|---|
| committer | Thomas Heijligen <src@posteo.de> | 2022-08-05 23:00:52 +0000 |
| commit | 36299dbab2397f25c4009339018065dc79d77452 (patch) | |
| tree | 73f92e50468d6d4de78547620e2eddd335c6ecc5 | |
| parent | 9e04991dc4bfdec3bd3ec65abf4261abbb5d6d6e (diff) | |
| download | flashrom-36299dbab2397f25c4009339018065dc79d77452.tar.gz flashrom-36299dbab2397f25c4009339018065dc79d77452.tar.bz2 flashrom-36299dbab2397f25c4009339018065dc79d77452.zip | |
pickit2_spi.c: Use a variable to store the total packetsize
Instead of calculating the total packetsize multiple times, use a
variable instead.
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Change-Id: I714054669e16dcf531a57174f9522b3af72d2754
Reviewed-on: https://review.coreboot.org/c/flashrom/+/66251
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-by: Thomas Heijligen <src@posteo.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | pickit2_spi.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/pickit2_spi.c b/pickit2_spi.c index 44db6934d..a0fcbb891 100644 --- a/pickit2_spi.c +++ b/pickit2_spi.c @@ -202,13 +202,14 @@ static int pickit2_spi_send_command(const struct flashctx *flash, unsigned int w const unsigned char *writearr, unsigned char *readarr) { struct pickit2_spi_data *pickit2_data = flash->mst->spi.data; + const unsigned int total_packetsize = writecnt + readcnt + 20; /* Maximum number of bytes per transaction (including command overhead) is 64. Lets play it safe * and always assume the worst case scenario of 20 bytes command overhead. */ - if (writecnt + readcnt + 20 > CMD_LENGTH) { + if (total_packetsize > CMD_LENGTH) { msg_perr("\nTotal packetsize (%i) is greater than %i supported, aborting.\n", - writecnt + readcnt + 20, CMD_LENGTH); + total_packetsize, CMD_LENGTH); return 1; } |