summaryrefslogtreecommitdiffstats
path: root/flashchips.h
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2020-04-15 12:59:42 +0200
committerAngel Pons <th3fanbus@gmail.com>2020-04-17 00:28:19 +0000
commitaa4aa16554c2e9961147cabafc347fc22dbafdc0 (patch)
treeaf632afb387523f07a2b416b9e127810ba1b6fa5 /flashchips.h
parente0fac2e4a655864c6c125e28918798502fe9651d (diff)
downloadflashrom-aa4aa16554c2e9961147cabafc347fc22dbafdc0.tar.gz
flashrom-aa4aa16554c2e9961147cabafc347fc22dbafdc0.tar.bz2
flashrom-aa4aa16554c2e9961147cabafc347fc22dbafdc0.zip
chipset_enable.c: Disable SPI on ICH7 if booted from LPC
Commit 92d6a86 ("Refactor Intel Chipset Enables") eliminated a check to disable SPI when ICH7 has booted from LPC, as the hardware does not support it. Therefore, when flashrom probes the SPI bus, it times out waiting for the hardware to react, for each and every SPI flash chip. This results in very long delays and countless instances of the error: Error: SCIP never cleared! To prevent this, bring back part of the lost check. Probing for LPC and FWH when booted from SPI does not seem to cause any problems on desktop mainboards with ICH7, so don't disable LPC nor FWH if that is the case. Tested on ECS 945G-M4 (ICH7, boots from LPC), works without errors. Change-Id: I5e59e66a2dd16b07f2dca410997fce38ab9c8fd1 Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/40401 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Diffstat (limited to 'flashchips.h')
0 files changed, 0 insertions, 0 deletions