summaryrefslogtreecommitdiffstats
path: root/ichspi.c
diff options
context:
space:
mode:
authorJonathon Hall <jonathon.hall@puri.sm>2022-10-03 16:12:11 -0400
committerAngel Pons <th3fanbus@gmail.com>2022-10-08 18:45:12 +0000
commit277b3fa670c548334a60c9fb5e66c2cc9e177f64 (patch)
tree38b7711b555bf1af618494fdf6c2ae0cd762017e /ichspi.c
parent5afd4aeecec3793e62f9b5af363ee300bc879167 (diff)
downloadflashrom-277b3fa670c548334a60c9fb5e66c2cc9e177f64.tar.gz
flashrom-277b3fa670c548334a60c9fb5e66c2cc9e177f64.tar.bz2
flashrom-277b3fa670c548334a60c9fb5e66c2cc9e177f64.zip
ichspi: Do not attempt to map physical memory for hwseq
ICH hwseq does not need to actually mmap flash, and this fails for flash chips >16 MB, since only the top 16 MB is mapped into the address space. Test: Read and write flash on ICH hwseq with 32 MB flash chip. Change-Id: Ie698071c3181e988f10b750b0e50c9700efaa1a3 Signed-off-by: Jonathon Hall <jonathon.hall@puri.sm> Reviewed-on: https://review.coreboot.org/c/flashrom/+/68090 Reviewed-by: Edward O'Callaghan <quasisec@chromium.org> Reviewed-by: Felix Singer <felixsinger@posteo.net> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'ichspi.c')
-rw-r--r--ichspi.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/ichspi.c b/ichspi.c
index 7e7967e07..aefbe2f9d 100644
--- a/ichspi.c
+++ b/ichspi.c
@@ -1794,8 +1794,6 @@ static const struct spi_master spi_master_ich9 = {
};
static const struct opaque_master opaque_master_ich_hwseq = {
- .map_flash_region = physmap,
- .unmap_flash_region = physunmap,
.max_data_read = 64,
.max_data_write = 64,
.probe = ich_hwseq_probe,